Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: search notes when searching through contacts #5103

Merged
merged 5 commits into from May 23, 2021

Conversation

iloveitaly
Copy link

This adds support for searching through notes as explained here. There are already tests for the contact search helper, but let me know if you feel like this functionality needs a dedicated test.

Checklist

Before submitting the PR

  • Read the CONTRIBUTING document before submitting your PR.
  • If the PR is related to an issue or fix one, don't forget to indicate it.
  • Create your PR as draft if it is not final yet. Mark it as ready... when it’s ready. Otherwise the PR will be considered complete and rejected if it's not working.

General checks

  • Make sure that the change you propose is the smallest possible.
  • The name of the PR should follow the conventional commits guideline that the project follows.

Backend/models changes

  • The API has been updated.
  • API's documentation has been added by submitting a pull request in the marketing website repository.
  • Tests have been added for the new code.
  • If you change a model, make sure the SetupTest file is updated. We need seeders to develop locally and generate fake data.

Other tasks

  • CHANGELOG entry added, if necessary, under UNRELEASED.
  • CONTRIBUTORS entry added, if necessary.
  • If it's relevant and worth mentioning, create a changelog entry for this change. The changelog entry will appear inside the UI for all users to see. To know if your change is worth the creation of a changelog entry, read the documentation.
  • Don't forget to ask for a free account on https://monicahq.com as anyone who contributes can request a free account.

@asbiin
Copy link
Member

asbiin commented Apr 27, 2021

Thank you @iloveitaly that's nice.
We'll definitely need a test for that feature!

@iloveitaly
Copy link
Author

@asbiin cool, I'll add a test for this. Thoughts on also searching through introduction notes as well? I'd like to add that as well in this PR if that works for you.

@iloveitaly
Copy link
Author

@asbiin added tests and search on introduction text!

@asbiin asbiin merged commit 6378bc1 into monicahq:master May 23, 2021
@asbiin
Copy link
Member

asbiin commented May 23, 2021

Thanks @iloveitaly !

@OctoberMedia
Copy link

OctoberMedia commented May 31, 2021

Great improvement Thanks to Iloveitaly. I'm curious as to how hard it would be to expand the search capability to include Activities (or for that matter, any of the other fields), As an example I played golf with 4 people at XYZ course. This is captured in the Activities field. It would really help to be able to search Activities, so we can get to a list of all contacts who were at that event. Or to be able to search by Company name or Company Title. Search is the most valuable function, and in my humble opinion is holding back monica

@OctoberMedia
Copy link

I have added a PR to expand on @iloveitaly search. The new PR includes search on conversations, phone calls and both the summary and description in a an activity

@github-actions
Copy link

🎉 This PR is included in version 3.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@djaiss
Copy link
Member

djaiss commented Jun 24, 2021

Unfortunately this is causing huge issues in production. We have to disable it until we find a fix.

@github-actions
Copy link

This pull request has been automatically locked since there
has not been any recent activity after it was closed.
Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants