Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix search being extremely slow #5306

Merged
merged 2 commits into from
Jun 24, 2021
Merged

fix: fix search being extremely slow #5306

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b752ff1
fix: fix search being extremely slow
djaiss Jun 24, 2021
3c0832d
wip
djaiss Jun 24, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions app/Helpers/SearchHelper.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,8 +48,6 @@ public static function searchContacts(string $needle, string $orderByColumn, str
}

return Contact::search($needle, $accountId, $orderByColumn, $orderByDirection)
->notes($accountId, $needle)
->introductionAdditionalInformation($accountId, $needle)
->addressBook($accountId, $addressBookName);
}
}
4 changes: 2 additions & 2 deletions tests/Unit/Helpers/SearchHelperTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ public function searching_for_contacts_returns_a_collection_with_pagination()
$this->assertCount(1, $searchResults);
}

/** @test */
/** disabled for now */
public function searching_with_notes()
{
$user = $this->signin();
Expand All @@ -46,7 +46,7 @@ public function searching_with_notes()
$this->assertCount(1, $searchResults);
}

/** @test */
/** disabled for now */
public function searching_with_introduction_information()
{
$user = $this->signin();
Expand Down