Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot turn off analytics #52

Closed
JanKoppe opened this issue Jul 6, 2016 · 3 comments
Closed

Cannot turn off analytics #52

JanKoppe opened this issue Jul 6, 2016 · 3 comments

Comments

@JanKoppe
Copy link

JanKoppe commented Jul 6, 2016

I am unable to turn off the analytics via the environment variable, XXL_analytics=false. The container fails with the log

$ sudo docker logs -f zabbix-server
Nginx status page: allowed address set to 127.0.0.1.
PHP-FPM status page: allowed address set to 127.0.0.1.
[LOG 20:35:07] Preparing XXL features
sed: -e expression #1, char 273: unknown command: `/'

I'm also really not sure, why they are turned on by default. This should be made way more prominent, if not turned off or removed entirely.

@jangaraj
Copy link
Member

jangaraj commented Jul 6, 2016

Thx Jan for your report. Please follow #51, it's should be already fixed in dev image.

@jangaraj jangaraj closed this as completed Jul 6, 2016
@JanKoppe
Copy link
Author

JanKoppe commented Jul 7, 2016

Thanks, didn't see that issue. It still leaves my question regarding the default settings open. This should concern more users, who maybe haven't noticed it.

@jangaraj
Copy link
Member

jangaraj commented Jul 7, 2016

If I use opt-in concept, then statistic dataset will be very small to get any reasonable knowledge. For example I've seen significant number of user from Japan, so I've added support for japanese font. It was win-win situation for me and also for users. Also free is not free - see Facebook, Google, .... The analytics provide useful insights mainly for R&D.

I work also for enteprise customers, so I know that any analytics collection can be a problem. Hopefully, infosec will stop project in that case. It was also reason for XXL_analytics=false switch. I've tried to add it transparently - it's in the readme + anybody can review code.
Feel free to create PR, if you know how to communicate it to users better. I'll be happy to review your PR.

Thanks Jan.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants