removed ServiceName dimension from CPUUtilization & MemoryUtilization… #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you Anthony. |
This was referenced May 21, 2019
jangaraj
pushed a commit
that referenced
this pull request
May 22, 2019
* Revert "removed ServiceName dimension from CPUUtilization & MemoryUtilization as default (#10)" This reverts commit 211c44d in order to rollback an unintended consequence of PR #10. In particular, after that change, the dashboards no longer display per service ECS metrics. * Create panels for CPU and memory queries not qualified by ServiceName metrics. The previous commit reverted that change to restore the per-service functionality and introduces two new panels to support the issue #9 that #10 was meant to address. Signed-off-by: Jon Seymour <jon@wildducktheories.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed "ServiceName": "$service" as default choices for CPUUtilization and MemoryUtilization since they give off error if not chosen.