Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basic implementation for getCell with MissingCellPolicy. #67

Merged
merged 4 commits into from
Jan 26, 2017
Merged

Basic implementation for getCell with MissingCellPolicy. #67

merged 4 commits into from
Jan 26, 2017

Conversation

waxxxd
Copy link
Contributor

@waxxxd waxxxd commented Jan 8, 2017

Will resolve the issues experienced in Issue #33 .

@monitorjbl
Copy link
Owner

Needs a unit test, but the code looks good. Add a test and I'll be good to merge this.

@waxxxd
Copy link
Contributor Author

waxxxd commented Jan 11, 2017

Will spin one up.

EDIT: Will take a while, busy.

@@ -579,4 +580,30 @@ public void shouldIgnoreSpreadsheetDrawingRows() throws Exception {
}
}
}

@Test
public void testShouldReturnNullForMissingCellPolicy_RETURN_BLANK_AS_NULL() throws Exception {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@monitorjbl monitorjbl merged commit a83c001 into monitorjbl:master Jan 26, 2017
@waxxxd
Copy link
Contributor Author

waxxxd commented Jan 26, 2017

Literally pushed another line for the JUnit 10 seconds after the approval. New pull request?

@monitorjbl
Copy link
Owner

Sure, that's fine. What you had looked alright to me, but more tests are always good to have.

@waxxxd
Copy link
Contributor Author

waxxxd commented Jan 26, 2017

Is just a negative confirmation without the missing cell policy, before the positive with the missing cell policy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants