Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does not work when target repo is a fork #17

Closed
majgis opened this issue Sep 15, 2015 · 10 comments
Closed

Does not work when target repo is a fork #17

majgis opened this issue Sep 15, 2015 · 10 comments
Labels
Milestone

Comments

@majgis
Copy link

majgis commented Sep 15, 2015

Default reviewers are not populating

Error in browser log when creating a PR:
GET http:///rest/pr-harmony/1.0/users// 404 (Not Found)

Any suggestions on what to look for?

Atlassian Stash v3.10.4

@monitorjbl
Copy link
Owner

Well, that's interesting...what is the full path to your Stash instance?

@monitorjbl
Copy link
Owner

Sorry, I meant like to something in the UI. Like the path to your repo.

@majgis
Copy link
Author

majgis commented Sep 15, 2015

http://build01.test.something.com/users/majgis/repos/test/browse

It is a repository under my profile (not a project).

@majgis
Copy link
Author

majgis commented Sep 15, 2015

I confirmed that this issue only occurs for repositories under a user profile. I created a project and did a PR and everything worked fine.

@majgis majgis changed the title GET http://<server>/rest/pr-harmony/1.0/users// 404 (Not Found) Repositories Under User Profile: GET http://<server>/rest/pr-harmony/1.0/users// 404 (Not Found) Sep 15, 2015
@monitorjbl
Copy link
Owner

Hm, that's interesting. I never tested for that explicitly but I'm kind of surprised it doesn't work. I'll have to take a look this weekend.

@majgis
Copy link
Author

majgis commented Sep 16, 2015

It isn't a deal breaker for our team, but it would be great to have a fix
before we deploy it.

I appreciate that you continue to maintain this project. Thanks you for
looking into it!
On Sep 15, 2015 23:16, "Taylor Jones" notifications@github.com wrote:

Hm, that's interesting. I never tested for that explicitly but I'm kind of
surprised it doesn't work. I'll have to take a look this weekend.


Reply to this email directly or view it on GitHub
#17 (comment)
.

@monitorjbl
Copy link
Owner

@majgis I published an RC version, would you be able to install it and see if it addresses your issue?

@monitorjbl monitorjbl changed the title Repositories Under User Profile: GET http://<server>/rest/pr-harmony/1.0/users// 404 (Not Found) Does not work when target repo is a fork Sep 22, 2015
@majgis
Copy link
Author

majgis commented Sep 23, 2015

Thank you. I will look into testing the RC version.

On Mon, Sep 21, 2015 at 7:57 PM, Taylor Jones notifications@github.com
wrote:

@majgis https://github.com/majgis I published an RC version
https://github.com/monitorjbl/pr-harmony/releases/tag/v1.7-RC3, would
you be able to install it and see if it addresses your issue?


Reply to this email directly or view it on GitHub
#17 (comment)
.

@majgis
Copy link
Author

majgis commented Sep 25, 2015

I was able to test v1.7-RC3 and I no longer see the issue. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants