Update Kafka producer and consumer to use Apache's Java Map construct… #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or to bypass classloader.
Avasil
reviewed
Nov 15, 2018
| @@ -270,6 +271,9 @@ case class KafkaProducerConfig( | |||
| "metrics.sample.window.ms" -> metricsSampleWindow.toMillis.toString | |||
| ) | |||
|
|
|||
| def toJavaMap: java.util.Map[String, Object] = | |||
| toMap.filter(_._2 != null).mapValues(_.asInstanceOf[AnyRef]).asJava | |||
There was a problem hiding this comment.
Is filtering null necessary? I believe optional are only ssl related configs and I think at least some of them accept null as valid value
There was a problem hiding this comment.
I get a NullPointerException for the partitioner when sending a message, unless I manage the partition value myself. This does not happen when using the properties version of the config and narrowed it down to this one difference.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…or to bypass classloader.
For #47