Skip to content
This repository has been archived by the owner on Feb 8, 2018. It is now read-only.

Commit

Permalink
Don't activate address breakpoints twice.
Browse files Browse the repository at this point in the history
2009-11-25  Martin Baulig  <martin@ximian.com>

	Don't activate address breakpoints twice.

	* classes/AddressBreakpoint.cs
	(AddressBreakpoint.NeedsActivation): Overwrite and return `false'.

	* frontend/Command.cs
	(BreakCommand.DoExecute): Check `Breakpoint.NeedsActivation' before
	calling Activate() on it.

svn path=/trunk/debugger/; revision=147673
  • Loading branch information
Martin Baulig committed Dec 4, 2009
1 parent 16a09fb commit b631f2f
Show file tree
Hide file tree
Showing 3 changed files with 17 additions and 1 deletion.
11 changes: 11 additions & 0 deletions ChangeLog
Original file line number Original file line Diff line number Diff line change
@@ -1,3 +1,14 @@
2009-11-25 Martin Baulig <martin@ximian.com>

Don't activate address breakpoints twice.

* classes/AddressBreakpoint.cs
(AddressBreakpoint.NeedsActivation): Overwrite and return `false'.

* frontend/Command.cs
(BreakCommand.DoExecute): Check `Breakpoint.NeedsActivation' before
calling Activate() on it.

2009-10-19 Martin Baulig <martin@ximian.com> 2009-10-19 Martin Baulig <martin@ximian.com>


* backend/Inferior.cs * backend/Inferior.cs
Expand Down
4 changes: 4 additions & 0 deletions classes/AddressBreakpoint.cs
Original file line number Original file line Diff line number Diff line change
Expand Up @@ -14,6 +14,10 @@ public override bool IsPersistent {
get { return false; } get { return false; }
} }


public override bool NeedsActivation {
get { return false; }
}

public TargetAddress Address { public TargetAddress Address {
get { return address; } get { return address; }
} }
Expand Down
3 changes: 2 additions & 1 deletion frontend/Command.cs
Original file line number Original file line Diff line number Diff line change
Expand Up @@ -3291,7 +3291,8 @@ protected override object DoExecute (ScriptingContext context)
return handle.Index; return handle.Index;


try { try {
handle.Activate (context.Interpreter.CurrentThread); if (handle.NeedsActivation)
handle.Activate (context.Interpreter.CurrentThread);
} catch { } catch {
if (!lazy) if (!lazy)
throw; throw;
Expand Down

0 comments on commit b631f2f

Please sign in to comment.