cure warning CS0253: Possible unintended reference comparison; to get a ... #127
Conversation
|
Hello! I'm the build bot for the Mono project. I need approval from a Mono team member to build this pull request. A team member should reply with "approve" to approve a build of this pull request, "whitelist" to whitelist this and all future pull requests from this contributor, or "build" to explicitly request a build, even if one has already been done. Contributors can ignore this message. |
2 similar comments
|
Hello! I'm the build bot for the Mono project. I need approval from a Mono team member to build this pull request. A team member should reply with "approve" to approve a build of this pull request, "whitelist" to whitelist this and all future pull requests from this contributor, or "build" to explicitly request a build, even if one has already been done. Contributors can ignore this message. |
|
Hello! I'm the build bot for the Mono project. I need approval from a Mono team member to build this pull request. A team member should reply with "approve" to approve a build of this pull request, "whitelist" to whitelist this and all future pull requests from this contributor, or "build" to explicitly request a build, even if one has already been done. Contributors can ignore this message. |
… a value comparison, cast the right hand side to type 'System.Delegate' A value comparison is what we want here. The C# equality operator will exactly do what is wanted here: check if a function is already in the list and, if yes, remove it. cf http://msdn.microsoft.com/en-us/library/system.delegate.op_equality(v=vs.100).aspx Change-Id: I64e85006140fca3d81e733f13d7e8cf17bfaa336 (cherry picked from commit 8009a2c) (cherry picked from commit 8009a2c)
MinnieTheMoocher
force-pushed
the
gtk-sharp-2-12-branch
branch
from
8009a2c
to
7e0ca62
Compare
|
ping, can please someone merge this warning removal? @duncanmak ? it just cures a build warning |
|
ping, can please someone merge this warning removal? @duncanmak ? it just cures a build warning |
cure warning CS0253: Possible unintended reference comparison; to get a ...
|
(I'm not a maintainer, but this seems strightforward enough that I can merge it safely) |
...value comparison, cast the right hand side to type 'System.Delegate'
A value comparison is what we want here. The C# equality operator will exactly do what is wanted here:
check if a function is already in the list and, if yes, remove it.
cf http://msdn.microsoft.com/en-us/library/system.delegate.op_equality(v=vs.100).aspx
Change-Id: I64e85006140fca3d81e733f13d7e8cf17bfaa336