Skip to content

Commit

Permalink
2002-04-24 Patrik Torstensson <patrik.torstensson@labs2.com>
Browse files Browse the repository at this point in the history 
	* string-icalls.c : String does now passes unit tests without any
	errors, the following changes has been made:

	Implemented replace methods.
	Renaming of methods to (try) follow the standard.
	Fixed compare ordinal
	Made all memory allocated directly to function instead of via icall function.
	Small performance fix in is_in_array function

 (2002-04-23) Changes from Duncan Mak <duncan@ximian.com>

	c (mono_string_Internal_ctor_charp_int_int):
	(mono_string_Internal_ctor_sbytep_int_int):  Removed check for
	sindex < 0, throw ArgumentOutOfRangeException instead of
	ArgumentNullException.

	Added new check for length == 0, however
	I need to make it return String.Empty from the C code.

	(mono_string_Internal_ctor_sbytep): Use mono_string_new, and let
	that calculate the length for us here.

	(mono_string_Internal_ctor_sbytep_int_int): Replaced
	mono_string_new_utf16 with mono_string_new, since value is utf8.

svn path=/trunk/mono/; revision=4029
  • Loading branch information
Patrik Torstensson committed Apr 24, 2002
1 parent b999b9c commit e5016b7
Show file tree
Hide file tree
Showing 4 changed files with 253 additions and 151 deletions.
26 changes: 26 additions & 0 deletions mono/metadata/ChangeLog
View file
Original file line number Diff line number Diff line change
@@ -1,3 +1,29 @@
2002-04-24 Patrik Torstensson <patrik.torstensson@labs2.com>

* string-icalls.c : String does now passes unit tests without any
errors, the following changes has been made:

Implemented replace methods.
Renaming of methods to (try) follow the standard.
Fixed compare ordinal
Made all memory allocated directly to function instead of via icall function.
Small performance fix in is_in_array function

(2002-04-23) Changes from Duncan Mak <duncan@ximian.com>

c (mono_string_Internal_ctor_charp_int_int):
(mono_string_Internal_ctor_sbytep_int_int): Removed check for
sindex < 0, throw ArgumentOutOfRangeException instead of
ArgumentNullException.

Added new check for length == 0, however
I need to make it return String.Empty from the C code.

(mono_string_Internal_ctor_sbytep): Use mono_string_new, and let
that calculate the length for us here.

(mono_string_Internal_ctor_sbytep_int_int): Replaced
mono_string_new_utf16 with mono_string_new, since value is utf8.

Wed Apr 24 18:43:29 CEST 2002 Paolo Molaro <lupus@ximian.com>

Expand Down
71 changes: 36 additions & 35 deletions mono/metadata/icall.c
View file
Original file line number Diff line number Diff line change
Expand Up @@ -1298,7 +1298,7 @@ ves_icall_Type_GetMethods (MonoReflectionType *type, guint32 bflags)
MonoMethod *method;
MonoObject *member;
int i, len, match;

domain = ((MonoObject *)type)->vtable->domain;
klass = startklass = mono_class_from_mono_type (type->type);

Expand Down Expand Up @@ -1345,6 +1345,7 @@ ves_icall_Type_GetMethods (MonoReflectionType *type, guint32 bflags)
for (; tmp; tmp = tmp->next, ++i)
mono_array_set (res, gpointer, i, tmp->data);
g_slist_free (l);

return res;
}

Expand Down Expand Up @@ -2129,40 +2130,40 @@ static gconstpointer icall_map [] = {
* System.String
*/

"System.String::.ctor(char*)", mono_string_Internal_ctor_charp,
"System.String::.ctor(char*,uint,uint)", mono_string_Internal_ctor_charp_int_int,
"System.String::.ctor(sbyte*)", mono_string_Internal_ctor_sbytep,
"System.String::.ctor(sbyte*,uint,uint)", mono_string_Internal_ctor_sbytep_int_int,
"System.String::.ctor(sbyte*,uint,uint,System.Text.Encoding)", mono_string_Internal_ctor_encoding,
"System.String::.ctor(char[])", mono_string_Internal_ctor_chara,
"System.String::.ctor(char[],uint,uint)", mono_string_Internal_ctor_chara_int_int,
"System.String::.ctor(char,uint)", mono_string_Internal_ctor_char_int,
"System.String::InternalEquals", mono_string_InternalEquals,
"System.String::InternalJoin", mono_string_InternalJoin,
"System.String::InternalInsert", mono_string_InternalInsert,
"System.String::InternalReplace(char,char)", mono_string_InternalReplaceChar,
"System.String::InternalReplace(string,string)", mono_string_InternalReplaceStr,
"System.String::InternalRemove", mono_string_InternalRemove,
"System.String::InternalCopyTo", mono_string_InternalCopyTo,
"System.String::InternalSplit", mono_string_InternalSplit,
"System.String::InternalTrim", mono_string_InternalTrim,
"System.String::InternalIndexOf(char,uint,uint)", mono_string_InternalIndexOfChar,
"System.String::InternalIndexOf(string,uint,uint)", mono_string_InternalIndexOfStr,
"System.String::InternalIndexOfAny", mono_string_InternalIndexOfAny,
"System.String::InternalLastIndexOf(char,uint,uint)", mono_string_InternalLastIndexOfChar,
"System.String::InternalLastIndexOf(string,uint,uint)", mono_string_InternalLastIndexOfStr,
"System.String::InternalLastIndexOfAny", mono_string_InternalLastIndexOfAny,
"System.String::InternalPad", mono_string_InternalPad,
"System.String::InternalToLower", mono_string_InternalToLower,
"System.String::InternalToUpper", mono_string_InternalToUpper,
"System.String::InternalAllocateStr", mono_string_InternalAllocateStr,
"System.String::InternalStrcpy(string,uint,string)", mono_string_InternalStrcpyStr,
"System.String::InternalStrcpy(string,uint,string,uint,uint)", mono_string_InternalStrcpyStrN,
"System.String::InternalIntern", mono_string_intern,
"System.String::InternalIsInterned", mono_string_is_interned,
"System.String::InternalCompare(string,uint,string,uint,uint,bool)", mono_string_InternalCompareStrN,
"System.String::GetHashCode", mono_string_GetHashCode,
"System.String::get_Chars", mono_string_get_Chars,
"System.String::.ctor(char*)", ves_icall_System_String_ctor_charp,
"System.String::.ctor(char*,uint,uint)", ves_icall_System_String_ctor_charp_int_int,
"System.String::.ctor(sbyte*)", ves_icall_System_String_ctor_sbytep,
"System.String::.ctor(sbyte*,uint,uint)", ves_icall_System_String_ctor_sbytep_int_int,
"System.String::.ctor(sbyte*,uint,uint,System.Text.Encoding)", ves_icall_System_String_ctor_encoding,
"System.String::.ctor(char[])", ves_icall_System_String_ctor_chara,
"System.String::.ctor(char[],uint,uint)", ves_icall_System_String_ctor_chara_int_int,
"System.String::.ctor(char,uint)", ves_icall_System_String_ctor_char_int,
"System.String::InternalEquals", ves_icall_System_String_InternalEquals,
"System.String::InternalJoin", ves_icall_System_String_InternalJoin,
"System.String::InternalInsert", ves_icall_System_String_InternalInsert,
"System.String::InternalReplace(char,char)", ves_icall_System_String_InternalReplace_Char,
"System.String::InternalReplace(string,string)", ves_icall_System_String_InternalReplace_Str,
"System.String::InternalRemove", ves_icall_System_String_InternalRemove,
"System.String::InternalCopyTo", ves_icall_System_String_InternalCopyTo,
"System.String::InternalSplit", ves_icall_System_String_InternalSplit,
"System.String::InternalTrim", ves_icall_System_String_InternalTrim,
"System.String::InternalIndexOf(char,uint,uint)", ves_icall_System_String_InternalIndexOf_Char,
"System.String::InternalIndexOf(string,uint,uint)", ves_icall_System_String_InternalIndexOf_Str,
"System.String::InternalIndexOfAny", ves_icall_System_String_InternalIndexOfAny,
"System.String::InternalLastIndexOf(char,uint,uint)", ves_icall_System_String_InternalLastIndexOf_Char,
"System.String::InternalLastIndexOf(string,uint,uint)", ves_icall_System_String_InternalLastIndexOf_Str,
"System.String::InternalLastIndexOfAny", ves_icall_System_String_InternalLastIndexOfAny,
"System.String::InternalPad", ves_icall_System_String_InternalPad,
"System.String::InternalToLower", ves_icall_System_String_InternalToLower,
"System.String::InternalToUpper", ves_icall_System_String_InternalToUpper,
"System.String::InternalAllocateStr", ves_icall_System_String_InternalAllocateStr,
"System.String::InternalStrcpy(string,uint,string)", ves_icall_System_String_InternalStrcpy_Str,
"System.String::InternalStrcpy(string,uint,string,uint,uint)", ves_icall_System_String_InternalStrcpy_StrN,
"System.String::InternalIntern", ves_icall_System_String_InternalIntern,
"System.String::InternalIsInterned", ves_icall_System_String_InternalIsInterned,
"System.String::InternalCompare(string,uint,string,uint,uint,bool)", ves_icall_System_String_InternalCompareStr_N,
"System.String::GetHashCode", ves_icall_System_String_GetHashCode,
"System.String::get_Chars", ves_icall_System_String_get_Chars,

/*
* System.AppDomain
Expand Down
Loading

0 comments on commit e5016b7

Please sign in to comment.