Catching IndexOutOfRange doesn't provide message

[nealef]

Steps to Reproduce

1. Compile code below
2. Run

using System;
using System.Text;

public class main{
        static void Main (string[] args)
        {
		int[,] myArray = new int[3, 2];
		try
		{
			int i1=myArray.GetLength(-1);
		}
		catch (System.IndexOutOfRangeException e)
		{
			//It should have this error: Index was outside the bounds of the array
			Console.WriteLine(" Where is the error message?? : " + e.Message);
		}
	}
}

Current Behavior

Output:

 Where is the error message?? : 

Expected Behavior

On Windows 10:

 Where is the error message?? : Index was outside the bounds of the array.

On which platforms did you notice this

[ ] macOS
[X ] Linux
[ ] Windows

Version Used:

• 5.18.0
• 6.5.0 (master/4e513f8)

Stacktrace

N/A

[nealef]

I can see the constructor setting the _message variable but the get() is retrieving an empty string from that same field.

  at System.Exception..ctor (System.String message) [0x00000] in <14160130308c4f7fb4091de819487fe0>:0 
  at System.SystemException..ctor (System.String message) [0x00000] in <14160130308c4f7fb4091de819487fe0>:0 
  at System.IndexOutOfRangeException..ctor () [0x00000] in <14160130308c4f7fb4091de819487fe0>:0 
  at System.Array.GetLength (System.Array , System.Int32 ) [0x00000] in <14160130308c4f7fb4091de819487fe0>:0 
  at main.Main (System.String[] args) [0x00000] in <ab54d575471047268cecc87c46052ddb>:0

The value of "this" is the same in the constructor:

[0x3ffb1a77740: 0.00247 6] ENTER: System.Exception:.ctor (string)(this:0x3ffaa800528[System.IndexOutOfRangeException 46400.exe], [STRING:0x3ffaaed8130:Index was outside the bounds of the array.], )

As in the get_Message:

[0x3ffb1a77740: 0.00287 4] ENTER: System.Exception:get_Message ()(this:0x3ffaa800528[System.IndexOutOfRangeException 46400.exe], )
[0x3ffb1a77740: 0.00287 4] LEAVE: System.Exception:get_Message ()[STRING:0x3ffaa800660:]

[nealef]

I added some code to just play around with the message being constructed:

--- a/mcs/class/referencesource/mscorlib/system/exception.cs
+++ b/mcs/class/referencesource/mscorlib/system/exception.cs
@@ -51,9 +51,12 @@ namespace System {
         , _Exception
 #endif
 {
+internal String _msgCopy;
+
         private void Init()
         {
             _message = null;
+_msgCopy = null;
             _stackTrace = null;
             _dynamicMethods = null;
             HResult = __HResults.COR_E_EXCEPTION;
@@ -80,6 +83,7 @@ namespace System {
         public Exception(String message) {
             Init();
             _message = message;
+_msgCopy = message;
         }
     
         // Creates a new Exception.  All derived classes should 
@@ -153,6 +157,7 @@ namespace System {
         
         public virtual String Message {
                get {  
+Console.WriteLine("copy: {0}",_msgCopy);
                 if (_message == null) {
                     if (_className==null) {
                         _className = GetClassName();

And now the output of the test case is as expected:

copy: Index was outside the bounds of the array.
 Where is the error message?? : Index was outside the bounds of the array.

[nealef]

It appears that #15705 has addressed this problem. There is a similar problem but I'm not sure it has the same genesis and it's not fixed by the PR. Here is the simple test case:

using System;
using System.Security;

public class main{
        static void Main (string[] args)
        {
		try
		{
			throw new XmlSyntaxException(5,"A silly error");
		}
		catch (XmlSyntaxException e)
		{
			//It should have this error: Index was outside the bounds of the array
			Console.WriteLine(" What is the error message?? : " + e.Message);
		}
	}
}

Under mono we get:

 What is the error message?? : System error.

On Windows we get:

 What is the error message?? : Invalid syntax on line 5 - 'A silly error'.

[vargaz]

Thats a different problem.
We are using corefx's version:

public sealed partial class XmlSyntaxException : SystemException
{
    public XmlSyntaxException() { }
    public XmlSyntaxException(int lineNumber) { }
    public XmlSyntaxException(int lineNumber, string message) { }
    public XmlSyntaxException(string message) { }
    public XmlSyntaxException(string message, Exception inner) { }
    private XmlSyntaxException(SerializationInfo info, StreamingContext context) : base(info, context) { }
}

[nealef]

Are you saying corefx would give the same result or that there is a problem but nothing to do with the original issue here? I'm trying to work out what to look at next.

[nealef]

@vargaz WRT XmlSyntaxException - should I open another issue or is this the behavior of corefx?