Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

X11 / excessive roundtrips to identify clipboard content #21268

Open
ThomasKuehne opened this issue Oct 30, 2021 · 0 comments
Open

X11 / excessive roundtrips to identify clipboard content #21268

ThomasKuehne opened this issue Oct 30, 2021 · 0 comments

Comments

@ThomasKuehne
Copy link
Contributor

Steps to Reproduce

  1. fill X11 clipboard - an way, other than with the mono application in step 2
  2. open mono application
  3. trigger in mono a request for the clipboard content

Current Behavior

XplatUIX11 iterates over all known formats from System.Windows.Forms.DataFormats
XplatUIX11 asks the clipboard owner to convert to each format, discards the conversion and only records if the conversion was successful

Expected Behavior

XplatUIX11 asks the clipboard owner for TARGETS (see ICCCM chapter 2.6.2. Target Atoms)
that way only 1 instead of 20 round trips are required and clipboard owner hasn't have to perform any data conversions

On which platforms did you notice this

[ ] macOS
[ X] Linux
[ ] Windows

Version Used:
Mono JIT compiler version 6.13.0 (main/9129a112 Wed Oct 27 11:30:12 PM UTC 2021)
ThomasKuehne added a commit to ThomasKuehne/mono that referenced this issue Oct 30, 2021
@ThomasKuehne
Fixes mono#21268 request X11 clipboard's TARGETS instead of every kno…
ca0d6b2 
…wn format

This reduces the round trips take do identify X11's clipboard content
from at least 21 - all Formats in DataFormats.Init - to just 1.
@ThomasKuehne ThomasKuehne mentioned this issue Oct 30, 2021
Closed
ThomasKuehne added a commit to ThomasKuehne/mono that referenced this issue Oct 30, 2021
@ThomasKuehne
Fixes mono#21268 request X11 clipboard's TARGETS instead of every kno…
65e3009 
…wn format

This reduces the round trips take do identify X11's clipboard content
from at least 21 - all Formats in DataFormats.Init - to just 1.

(cherry picked from commit ca0d6b2)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes #21268 request X11 clipboard's TARGETS instead of every known format ThomasKuehne/mono
1 participant
@ThomasKuehne