DynamicMethod creation fails with "method arguments are incompatible"

[bojanrajkovic]

Steps to Reproduce

1. Attempt to create a DynamicMethod with an owner type, and an arguments list that includes the owner type as the first parameter (ala a this pointer).
2. Call CreateDelegate and pass a delegate type that does not have the owner type as the first argument.

Sample code: https://gist.github.com/bojanrajkovic/aa447f5a46904c5b72b9d4c46c554ff6

You can compile the sample code with csc delegate.cs and running it with Mono will be broken, running with .NET Framework or .NET Core will be fine.

This affects dotnet/machinelearning, as it throws exceptions on Mono even with native libraries in place.

Current Behavior

Delegate creation fails with "method arguments are incompatible"

Expected Behavior

A delegate is created

On which platforms did you notice this

• macOS
• Linux
• Windows

Version Used:

Mono JIT compiler version 5.10.1.47 (2017-12/8eb8f7d5e74 Fri Apr 13 20:18:12 EDT 2018)

Stacktrace

ArgumentException: method arguments are incompatible
at Delegate System.Delegate.CreateDelegate (Type type, object firstArgument, MethodInfo method, bool throwOnBindFailure, bool allowClosed)
at Delegate System.Delegate.CreateDelegate (Type type, MethodInfo method, bool throwOnBindFailure)
at Delegate System.Delegate.CreateDelegate (Type type, MethodInfo method)
at Delegate System.Reflection.Emit.DynamicMethod.CreateDelegate (Type delegateType)
at Delegate .GeneratePeek<string, int, Foo> (FieldInfo fieldInfo, OpCode assignmentOpCode)
at void System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw ()
at void System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess (Task task)
at void System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification (Task task)
at void System.Runtime.CompilerServices.TaskAwaiter.ValidateEnd (Task task)
at object System.Runtime.CompilerServices.TaskAwaiter<object>.GetResult ()
at void Xamarin.Interactive.CodeAnalysis.EvaluationContext.<RunAsync>d__26.MoveNext ()

[sandyarmstrong]

For reference, gist is based on https://github.com/dotnet/machinelearning/blob/v0.2.0/src/Microsoft.ML.Api/ApiUtils.cs.

[kumpera]

FIX: #9067