[merp] Fix return value handling of posix_spawn #10823
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 26, 2018
luhenry
approved these changes
Sep 26, 2018
jaykrell
reviewed
Sep 26, 2018
mono/utils/mono-merp.c
Outdated
| // // FIXME error handling | ||
| if (status == 0) | ||
| g_error ("Could not start merp\n"); | ||
| g_assertf (status == 0, "Could not start merp\n"); |
There was a problem hiding this comment.
g_assertf (status == 0, "Could not start merp (%d)\n", status);?
g_assertf (status == 0, "posix_spawn(/usr/bin/open %s) failed with status:%d\n", config.merpGUIPath, status);?
Granted, if things are bad, formating of the assert message is risky; it requires heap. The way to handle that is do allocations/formats in startup, leaving as little work as possible for the error path. And heap-free putting in the status.
alexanderkyte
force-pushed
the
merp_return_fixup
branch
from
5b2eaa5
to
cb0cf74
Compare
|
It seems the 2018-02 backport was merged. I'm not going to revert that. I will close and update my updated error formatting to the 2018-04 and 2018-06 PRs. |
|
@monojenkins backport 2018-06 |
|
@monojenkins backport 2018-04 |
This was referenced Sep 26, 2018
|
@monojenkins build failed |
akoeplinger
added a commit
that referenced
this pull request
Sep 27, 2018
It was missing the format arguments that were in a later iteration of #10823
|
@monojenkins backport 2018-08 |
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
Commit migrated from mono/mono@a7d355d
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@slluis requested this change be merged by tomorrow to make a release window