Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[2018-10] Added missing cts.Cancel() in HttpClient Dispose() method #11539

Merged
merged 1 commit into from
Nov 6, 2018
Merged

[2018-10] Added missing cts.Cancel() in HttpClient Dispose() method #11539

merged 1 commit into from
Nov 6, 2018

Conversation

monojenkins
Copy link
Contributor

Backport of #11442.

/cc @marek-safar @domino46

Description:
Fixes #11441

@monojenkins monojenkins added this to the 2018-10 (5.20.xx) milestone Nov 3, 2018
@lewurm
Copy link
Contributor

lewurm commented Nov 6, 2018

@monojenkins build failed

@lewurm
Copy link
Contributor

lewurm commented Nov 6, 2018

@monojenkins squash

@monojenkins
Copy link
Contributor Author

Cannot squash because the following required status checks are not successful:

  • "Linux AArch64" state is "failure"

@lewurm
Copy link
Contributor

lewurm commented Nov 6, 2018

@monojenkins build failed

@monojenkins monojenkins merged commit f5e27e1 into mono:2018-10 Nov 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luhenry luhenry luhenry approved these changes

@akoeplinger akoeplinger Awaiting requested review from akoeplinger akoeplinger is a code owner

@marek-safar marek-safar Awaiting requested review from marek-safar marek-safar is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2018-10 (5.20.xx)
Development

Successfully merging this pull request may close these issues.
4 participants
@monojenkins @lewurm @luhenry @dominikprzywara