[2018-10] Fix starting process with empty environment incorrectly inherits all variables #11644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
monojenkins
requested review from
akoeplinger and
marek-safar
as code owners
luhenry
approved these changes
Nov 12, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes starting a process with an empty environment variable collection in
ProcessStartInfo. As per the issue it fixes a regression that it used to work but currently an empty environment variable collection works like it was never touched.I also made a minor fix to remove the
StringBuilderbecause a simplestring.Concatdoes the job without theStringBuilderallocation and overhead.I've included unit tests. Please let me know if you'd like any changes.
Fixes #8766
Backport of #11630.
/cc @marek-safar @jonorossi