Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[do-not-merge] [bockbuild] make macOS package with debug flags enabled #11706

Closed
wants to merge 5 commits into from

Conversation

lewurm
Copy link
Contributor

@lewurm lewurm commented Nov 15, 2018

@monojenkins skip

@akoeplinger @alexischr I want to get a macOS package that is compiled with CFLAGS='-O0 -ggdb3', is that the correct way to do it?

Context: dotnet/android#2357

@lewurm
Copy link
Contributor Author

lewurm commented Nov 15, 2018

@monojenkins build OS X Package

@akoeplinger
Copy link
Member

akoeplinger commented Nov 15, 2018

@lewurm no, you need to push to a branch in mono/bockbuild and then bump the submodule to that, it won't work from a fork I think. actually, it should just work since you edited the .gitmodules

@akoeplinger
Copy link
Member

The change itself looks good

@akoeplinger
Copy link
Member

@monojenkins build OS X Package

@lewurm
Copy link
Contributor Author

lewurm commented Nov 22, 2018

@monojenkins build OS X Package

Add the parent pid.
@luhenry
Copy link
Contributor

luhenry commented Nov 26, 2018

@monojenkins build OS X Package

@luhenry
Copy link
Contributor

luhenry commented Nov 27, 2018

@monojenkins build OS X Package

jonpryor pushed a commit to dotnet/android that referenced this pull request Nov 30, 2018
Context: mono/mono#11706
Context: #2357
Context: https://jenkins.mono-project.com/view/Xamarin.Android/job/xamarin-android/1239/console

Sometimes a Jenkins build will timeout when executing the
xamarin-android unit tests.  The timeout *appears* to occur when
`mono` is used to execute a process, the process "finishes," but the
process never actually *exits*, thus "hanging".

For example, [consider this build log fragment][0] (with timestamps):

	23:37:48   Build succeeded.
	23:37:48       0 Warning(s)
	23:37:48       0 Error(s)
	23:37:48
	23:37:48   Time Elapsed 01:23:14.60
	02:37:48 Build timed out (after 180 minutes). Marking the build as aborted.

The "Build succeeded" message comes from an `msbuild` invocation.
Once `msbuild` finished, we would expect it's process to exit.
*It didn't*.  Instead, the underlying `mono` process is *not* exiting,
presumably deadlocked, until the overall job times out and is killed.

Attempt to help identify the hang by using a "debug" mono/2018-08
system mono, built from [Mono PR #11706][1], which prints out
additional messages around child process use:

	diff --git a/mono/metadata/w32process-unix.c b/mono/metadata/w32process-unix.c
	index 2db5dea7a705..fbd4731cacb2 100644
	--- a/mono/metadata/w32process-unix.c
	+++ b/mono/metadata/w32process-unix.c
	@@ -2096,7 +2095,7 @@ process_create (const gunichar2 *appname, const gunichar2 *cmdline,
	 	if (argv)
	 		g_strfreev (argv);
 
	-	mono_trace (G_LOG_LEVEL_DEBUG, MONO_TRACE_IO_LAYER_PROCESS, "%s: returning handle %p for pid %d", __func__, handle, pid);
	+	g_printerr ("XXX-MONO: %s: returning handle %p for pid %d from %d\n", __func__, handle, pid, getpid());

This will hopefully allow @lewurm to continue investigations.

[0]: https://jenkins.mono-project.com/view/Xamarin.Android/job/xamarin-android/1237/console
[1]: mono/mono#11706
@luhenry luhenry changed the base branch from 2018-06 to 2018-08 January 9, 2019 11:26
@luhenry luhenry changed the base branch from 2018-08 to 2018-06 January 9, 2019 11:27
@lewurm lewurm closed this Apr 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants