[mini] Add mini_target_safepoints_enabled #11817
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TODO: Differentiate between host and target settings for this. It could be that the targets needs safepoints even if the default on the host is not to use safepoints.
Check is safepoints are enabled on the target, not the host.
Even if we're cross-compiling and the host doesn't use safepoints. This should address mono#11765 which, due to mono/monodevelop#6327, was not emitting safepoints in the watchOS cross-compiler since the host had `MONO_THREADS_SUSPEND=preemptive` set.
|
This isn't totally wrong, but I need to rethink it. We should also decide in So this shouldn't go in mini, it should go in metadata. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows us to emit safepoints for the target even if the host doesn't need them.
Always emit safepoints when targeting watchOS. This should address #11765: due to mono/monodevelop#6327, Mono was not emitting safepoints in the watchOS cross-compiler since the host had
MONO_THREADS_SUSPEND=preemptiveset.