[2018-12] [corlib] Import FileSystemInfo and family from CoreFX #11963
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test that runs on Mono (004.1) claims to assert that SetLastError works for pInvokes, but fails to use the Flag when declaring the used pInvoke so it was testing that the last errno happened to be zero. If fixed to use the flag, the test fails as the errno after getenv() is 13; this may be a Mono bug or something else broken with the test
monojenkins
requested review from
akoeplinger,
alexischr,
baulig,
directhex,
EgorBo,
kg,
lewurm,
luhenry and
marek-safar
as code owners
|
@alexischr I'd rather not backport this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes the following from System.IO:
Join()Span APIand all of System.IO.Enumeration namespace.
Adds about 1600 System.IO tests
Behavior changes:
File.Replacenow replaces files even if they are read-only (using therenamesyscall on Unix)Issues:
Part of #7246
Backport of #11342.
/cc @alexischr