Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for ARM v5 CPU info #1211

Closed
wants to merge 1 commit into from

Conversation

Mailaender
Copy link
Contributor

Yet another undocumented patch from https://build.opensuse.org/package/show/Mono:Factory/mono-core. I can only guess what it does. Uploaded it here for review.

@monoadmin
Copy link

Hello! I'm the build bot for the Mono project. I need approval from a Mono team member to build this pull request. A team member should reply with "approve" to approve a build of this pull request, "whitelist" to whitelist this and all future pull requests from this contributor, or "build" to explicitly request a build, even if one has already been done. Contributors can ignore this message.

@Mailaender
Copy link
Contributor Author

This is probably not necessary anymore.

@Mailaender Mailaender closed this Aug 16, 2014
@Mailaender Mailaender deleted the arm-cpuinfo-v5 branch August 16, 2014 15:04
@alexrp
Copy link
Contributor

alexrp commented Aug 17, 2014

We actually support ARM v4, so this isn't technically correct either.

(That said, I have no idea what kind of state our ARM v4 support is in since nobody seems to have v4 hardware anymore.)

@monoadmin
Copy link

Hello! I'm the build bot for the Mono project. I need approval from a Mono team member to build this pull request. A team member should reply with "approve" to approve a build of this pull request, "whitelist" to whitelist this and all future pull requests from this contributor, or "build" to explicitly request a build, even if one has already been done. Contributors can ignore this message.

@kumpera
Copy link
Contributor

kumpera commented Aug 17, 2014

This patch adds dead code, we should not be doing it.

@Mailaender
Copy link
Contributor Author

Yeah, I read

    v5_supported = mono_hwcap_arm_is_v5;
    v6_supported = mono_hwcap_arm_is_v6;
    v7_supported = mono_hwcap_arm_is_v7;
    v7s_supported = mono_hwcap_arm_is_v7s;

some lines above and then decided to close this.

So I guess I can also throw away

then?

@alexrp
Copy link
Contributor

alexrp commented Aug 17, 2014

Yes - these hacks should no longer be necessary. We've sanitized the way the runtime detects CPU features on ARM.

@Mailaender
Copy link
Contributor Author

AlexKnauth pushed a commit to AlexKnauth/mono that referenced this pull request Nov 2, 2023
…pe-exception

[metadata] Fields whose types are gparams with a reference type const…
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants