Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[asp.net] Implement the EventHandlerTaskAsyncHelper and HttpTaskAsyncHandler classes #1365

Closed
wants to merge 1 commit into from

Conversation

kornelpal
Copy link
Contributor

No description provided.

@monoadmin
Copy link

Hello! I'm the build bot for the Mono project. I need approval from a Mono team member to build this pull request. A team member should reply with "approve" to approve a build of this pull request, "whitelist" to whitelist this and all future pull requests from this contributor, or "build" to explicitly request a build, even if one has already been done. Contributors can ignore this message.

@martinjt
Copy link
Contributor

I'm not in a position to do a technical review, I just wanted to say thanks as I was going to be spending a long time trying to work out how to do it!

I've looked at it from a coding standards perspective and looks ok.

You'll need to follow this up with a message to the mono-dev-list.

@@ -1249,6 +1249,7 @@
<Compile Include="System.Web\DefaultExceptionPageTemplate.cs" />
<Compile Include="System.Web\DefaultHttpHandler.cs" />
<Compile Include="System.Web\EndEventHandler.cs" />
<Compile Include="System.Web\EventHandlerTaskAsyncHelper.cs" />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The csproj files shouldn't be amended, they are auto generated.

@kornelpal kornelpal force-pushed the task-async-wrappers branch 6 times, most recently from 4491cc8 to c10502c Compare October 27, 2014 10:02
@migueldeicaza
Copy link
Contributor

Merged manually.

@migueldeicaza
Copy link
Contributor

ma

@kornelpal kornelpal deleted the task-async-wrappers branch November 2, 2014 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants