[2018-10] [amd64] use 32bit variant of lea_membase for 32bit operations #13651
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Consider ``` xor %r15, %r15 // %r15 = 0x0 dec %r15d // %r15 = 0xffff_ffff lea 0x1(%r15), %rdx // %rdx = 0x1_0000_0000 but should be 0x0 ``` instead `lea 0x1(%r15), %edx` should be generated.
|
@monojenkins squash |
lewurm
approved these changes
Mar 25, 2019
|
Cannot squash because the following required status checks are not successful:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Consider
instead
lea 0x1(%r15), %edxshould be generated.Fixes #13452
Fixes #13597
Backport of #13642.
/cc @lewurm