Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update SecurityProtocolType to support Tls 1.3 #14378

Closed
wants to merge 1 commit into from

Conversation

woutermeuwis
Copy link

No description provided.

@spouliot
Copy link
Contributor

spouliot commented May 7, 2019

It's the System.Net (not Mono.Security) copy of the enum that needs the update.

The file you want to update is external/corefx/src/System.Net.ServicePoint/src/System/Net/SecurityProtocolType.cs which is in the corefx repo (and a more recent version, than the current revision used by mono, might already have the value).

@sdebruyn
Copy link

sdebruyn commented May 7, 2019

@spouliot It seems to be already updated, to which commit should the CoreFX submodule be updated?

@spouliot
Copy link
Contributor

spouliot commented May 7, 2019

@SamuelDeBruyn bumping the revision of corefx has a lot of implications.
@marek-safar might be able to tell you when the next bumps will happen (and if they go over the one that include the change you're looking for)

@marek-safar
Copy link
Member

As @spouliot said the correct place to update the value is in mono/corefx repo, please make PR there with suggested change

@woutermeuwis
Copy link
Author

As @spouliot said the correct place to update the value is in mono/corefx repo, please make PR there with suggested change

@marek-safar As mentioned above by @SamuelDeBruyn it is already updated in there (november 2018). So in order to get those changes we would need the version bumped up. Can you give a timeline on when to expect this?

@marek-safar
Copy link
Member

@akoeplinger
Copy link
Member

Should be fixed by #14660

@hiradyazdan
Copy link

hiradyazdan commented Sep 10, 2019

@akoeplinger is this PR merged for latest mono (6.0.0.327) and available on mono runtime 4.0.3? If so, I'm curious as to whether this would be available on latest Unity as well?

@akoeplinger
Copy link
Member

@hiradyazdan it's available in Mono 6.4.0.190 and later. I don't know when it will show up in Unity, you need to ask them :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants