[Profiler] Limit files loaded in the coverage profiler to 128k #1823
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -3054,6 +3056,11 @@ get_file_content (FILE *stream) | |||
|
|
|||
| while ((bytes_read = fread (buffer, 1, LINE_BUFFER_SIZE, stream)) > 0) { | |||
| g_string_append_len (builder, buffer, bytes_read); | |||
|
|
|||
| if (builder->len > MAX_FILE_SIZE) { | |||
There was a problem hiding this comment.
I think it'd be best to get the file size with fseek / ftell. Then you could also pre-size the string with the right size.
Place an upper limit on files loaded in the coverage profiler to 128k. If the system suppression file exceeds that (it is currently only 3k), then there's some problem and the profiler will exit. For other user files passed on the commandline, we print a warning message and ignore them.
alexrp
added a commit
that referenced
this pull request
May 20, 2015
[Profiler] Limit files loaded in the coverage profiler to 128k
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
[Profiler] Limit files loaded in the coverage profiler to 128k Commit migrated from mono/mono@134c7af
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Place an upper limit on files loaded in the coverage profiler to 128k. If the
system suppression file exceeds that (it is currently only 3k), then there's
some problem and the profiler will exit. For other user files passed on the
commandline, we print a warning message and ignore them.