Keventwatcher throws exceptions #1910
Conversation
|
Hey @vlomshakov, However, it looks like you haven't signed our CLA (Contributor License Agreement) yet. In order for us to accept your pull request, you have to sign our CLA first. You can read and sign our full Contributor License Agreement here. Thanks, Your friendly Xamarin CLA Bot# |
|
Hello! I'm the build bot for the Mono project. I need approval from a Mono team member to build this pull request. A team member should reply with "approve" to approve a build of this pull request, "whitelist" to whitelist this and all future pull requests from this contributor, or "build" to explicitly request a build, even if one has already been done. Contributors can ignore this message. |
|
Hey @vlomshakov, Thanks for signing our CLA! We can now look at your pull request. Always at your service, Your friendly Xamarin CLA Bot# |
|
Given that there are some whitespace differences between your commits, I think it's better that you squash all your commits into a single one (you can use git rebase for this, and then push -f). |
… when path equals to fullPathNoLastSlash; fix exception ArgumentOutOfRangeException in KqueueMonitor.GetFilenameFromFd, when new path is shorter than old one; add tests
|
Please merge this if it's ok |
|
is there still interest to merge this or should it be closed? |
|
@alexischr can take care of this please? |
|
We do not use KeventWatcher anymore, but I think this fix is still sound (if it wasn't fixed since 2016 yet) |
|
Closing in favour of #5973 |
FileSystemWatcher with KeventWatcher backend throws excpetions under MacOS (kernel 14.3.0).
I added tests and straightforward fixes.