Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mono: Use the relocated directory for finding support libraries in data/config #1937

Merged
merged 1 commit into from
Jul 23, 2015

Conversation

lewurm
Copy link
Contributor

@lewurm lewurm commented Jul 23, 2015

based on a patch suggested by @migueldeicaza.

is the usage of strncat okay here or is there a eglib equivalent that should be used?

@xamarin-cla-bot
Copy link

Hey @lewurm,
Thank you for your Pull Request! We <3 our contributors!

However, it looks like you haven't signed our CLA (Contributor License Agreement) yet. In order for us to accept your pull request, you have to sign our CLA first.
Once you do this, we can check over your pull request. You should only have to do this once.

You can read and sign our full Contributor License Agreement here.

Thanks,

Your friendly Xamarin CLA Bot#

@monojenkins
Copy link
Contributor

Hello! I'm the build bot for the Mono project. I need approval from a Mono team member to build this pull request. A team member should reply with "approve" to approve a build of this pull request, "whitelist" to whitelist this and all future pull requests from this contributor, or "build" to explicitly request a build, even if one has already been done. Contributors can ignore this message.

@lewurm lewurm mentioned this pull request Jul 23, 2015
migueldeicaza added a commit that referenced this pull request Jul 23, 2015
mono: Use the relocated directory for finding support libraries in data/config
@migueldeicaza migueldeicaza merged commit 70920b3 into mono:master Jul 23, 2015
if (match != NULL) {
/* substitude $mono_libdir */
const char *libdir = mono_assembly_getrootdir ();
const int libdir_len = strlen (libdir);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

strlen returns size_t.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! #1949

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants