Set ErrorInfo #218
Merged
Set ErrorInfo #218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also use additional information provided by IErrorInfo to fill in exception details. To make use of IErrorInfo on Linux a suitable implementation has to be provided, e.g. by including libcom plus adding a mapping from oleauth32.dll to the shared library that provides the implementation. This completes mono bug 496138 (https://bugzilla.novell.com/show_bug.cgi?id=496138)
Marshal.GetHRForException had a MonoTODO because it needs to set the errorinfo object so that exceptions get properly passed to unmanaged code. Since not all managed exceptions have a corresponding HR value but we might need to get to the original thrown exception we implement a ManagedErrorInfo helper class that implements the IErrorInfo interface but also stores the exception. In GetExceptionForHR we check if the errorinfo we get is a ManagedErrorInfo. If it is we return the exception stored in there (if it converts to the same error code), otherwise we construct a new exception. Change-Id: Ib400636ee3caa54c9db8f41dbd40f15710024a63
|
Thanks for the patch! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes implement setting and getting the error info in the Marshal class. This is necessary to pass error information to/from unmanaged code.
To successfully use this code on Linux there needs to be an implementation of the Get/SetErrorInfo methods available, e.g. by installing libcom (http://linux.lsdev.sil.org/svn/COM/trunk/; http://linux.lsdev.sil.org/wiki/index.php/Libcom). However, the new code has try/catch blocks around so if Get/SetErrorInfo methods can't be found it behaves as before.