[coop] Synchronization primitive friendliness #2231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luhenry
force-pushed
the
coop-sync-friendliness
branch
12 times, most recently
from
42c91e1
to
505f0a4
Compare
|
@lambdageek @kumpera whenever you have time, would you mind reviewing this PR? Thank you! :) |
|
For some numbers: when running |
luhenry
force-pushed
the
coop-sync-friendliness
branch
2 times, most recently
from
9720459
to
816fe45
Compare
|
What's causing the 10x reduction in transitions? This change should, if anything, increased the number of transitions. |
|
luhenry@d435639#diff-df675e7de49d2766cf7cbd6956a00699R50 is what reduces the amount of transitions. We could do the same for semaphores, but we would need to add |
Move all the code to mono-mutex.c, so it will be easier to make it coop suspend friendly.
Move all the code to mono-semaphore.c, so it will be easier to make it coop suspend friendly.
This is to separate from the mono_coop_* mutex and semaphores
Instead of having to use MONO_PREPARE_BLOCKING/MONO_TRY_BLOCKING in the user code, we do it directly in this new mutex and semaphore coop API. Using the mono_os_* locking functions should not be the default case, as that could lead to longer than necessary time to suspend, and even in certain cases to deadlocks.
…>initialization_section to coop implementation
luhenry
force-pushed
the
coop-sync-friendliness
branch
3 times, most recently
from
cc938b4
to
bf5c534
Compare
Switching to blocking should only be done when actually blocking (ex: mutex lock, sem wait, cond wait, blocking syscalls), and not around a whole section. This means that blocking can only be a leaf state, and we should not switch from blocking to blocking mode again.
luhenry
force-pushed
the
coop-sync-friendliness
branch
from
bf5c534
to
4666757
Compare
akoeplinger
added a commit
that referenced
this pull request
Dec 1, 2015
Provided by Tom Hindle in https://bugzilla.xamarin.com/show_bug.cgi?id=2033#c5
kumpera
added a commit
that referenced
this pull request
Dec 2, 2015
[coop] Synchronization primitive friendliness
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.