Make make fullaotcheck in mono/mini runnable on Windows
#2777
Conversation
| @@ -1,6 +1,8 @@ | |||
| count=100000 | |||
| mtest=for_loop | |||
| monodir=$(top_builddir) | |||
| mono=$(if $(MONO_EXECUTABLE),$(MONO_EXECUTABLE),mono) | |||
| sep=$(if $(LIST_SEPARATOR),$(LIST_SEPARATOR),:) | |||
There was a problem hiding this comment.
In the mcs/ build system this is called $(PLATFORM_PATH_SEPARATOR) (just for sake of consistency).
There was a problem hiding this comment.
And instead of needing to pass this in from the outside, you could do:
if HOST_WIN32
PLATFORM_PATH_SEPARATOR=;
else
PLATFORM_PATH_SEPARATOR=:
endif
There was a problem hiding this comment.
Here is a problem: If we are running this from Cygwin, we need to potentially be able to support EITHER running a cygwin-built mono OR a msvc-built mono. Will the cygwin-built mono use ; or : as its separator?
There was a problem hiding this comment.
Hmm, good question. We use glib for that, so whatever G_SEARCHPATH_SEPARATOR_S happens to be:
Line 261 in 5980629
There was a problem hiding this comment.
*-*-msdos* | *-*-go32* | *-*-mingw32* | *-*-cygwin* | *-*-windows*)
PATHSEP='\\'
SEARCHSEP=';'
Hm, this says to me that ALL HOST_WIN32 platforms use the semicolon.
|
LGTM otherwise. |
Test harness now uses the proper path separator and also now supports MONO_EXECUTABLE if you built with MSVC.
xmcclure
force-pushed
the
win-makefile-aotcheck
branch
from
c82b640
to
9a1720e
Compare
|
Addressed the "otherwise", so based on that LGTM: @monojenkins merge |
Make `make fullaotcheck` in mono/mini runnable on Windows Run with MONO_EXECUTABLE=/path/to/msvc/mono.exe LIST_SEPARATOR=";" This assumes you are running the test harness in Cygwin and you built mono with MSVC. Also, the test does not currently succeed. Being able to run the test is a zeroth step toward making the test pass.
Make `make fullaotcheck` in mono/mini runnable on Windows Run with MONO_EXECUTABLE=/path/to/msvc/mono.exe LIST_SEPARATOR=";" This assumes you are running the test harness in Cygwin and you built mono with MSVC. Also, the test does not currently succeed. Being able to run the test is a zeroth step toward making the test pass. Commit migrated from mono/mono@65e51c5
Run with
MONO_EXECUTABLE=/path/to/msvc/mono.exe LIST_SEPARATOR=";"
This assumes you are running the test harness in Cygwin and you built mono with MSVC. Also, the test does not currently succeed.
Being able to run the test is a zeroth step toward making the test pass.