Fixes socket timeout on non-blocking Connect() #3368
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, a non-blocking Connect() call using the IPAddress[] overload would block forever. This does not match either the mono Connect(IPEndPoint) overload or the .NET Core and Windows .NET Framework implementations, which throw the socket exception immediately on a Connect() error. This fixes that error, and allows for a timeout on the Connect() method. This change is released under the MIT license.
|
Hello! I'm the build bot for the Mono project. I need approval from a Mono team member to build this pull request. A team member should reply with "approve" to approve a build of this pull request, "whitelist" to whitelist this and all future pull requests from this contributor, or "build" to explicitly request a build, even if one has already been done. Contributors can ignore this message. |
|
build |
|
The |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, a non-blocking Connect() call using the IPAddress[] overload would block forever. This does not match either the mono Connect(IPEndPoint) overload or the .NET Core and Windows .NET Framework implementations, which throw the socket exception immediately on a Connect() error. This fixes that error, and allows for a timeout on the Connect() method.
Error reported at https://bugzilla.xamarin.com/show_bug.cgi?id=13416
This change is released under the MIT license.