Disable some flaky tests and harden another one. #4376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… and system timers. The disabled tests assume perfect scheduling and non-coalescing system timers. Neither exists on OSX Sierra, iOS or Android. This tests fail there regularly.
marek-safar
requested changes
Feb 15, 2017
| Thread.Sleep (1000); | ||
| Assert.IsTrue(bucket.count > 20, "#4"); | ||
| using (Timer t = new Timer (o => Callback2 (o), bucket, 200, Timeout.Infinite)) { | ||
| bucket.mre.Wait (5000); |
There was a problem hiding this comment.
Should do Assert.True (...)
| Bucket bucket = new Bucket(); | ||
|
|
||
| using (Timer t = new Timer (o => Callback2 (o), bucket, 10, 10)) { | ||
| bucket.mre.Wait (5000); |
There was a problem hiding this comment.
Should do Assert.True (...)
| using (Timer t = new Timer (o => Callback (o), bucket, 10, 10)) { | ||
| Thread.Sleep (500); | ||
| using (Timer t = new Timer (o => Callback2 (o), bucket, 10, 10)) { | ||
| bucket.mre.Wait (5000); |
There was a problem hiding this comment.
Should do Assert.True (...)
| using (Timer t = new Timer (o => Callback (o), bucket, 0, Timeout.Infinite)) { | ||
| Thread.Sleep (100); | ||
| using (Timer t = new Timer (o => Callback2 (o), bucket, 0, Timeout.Infinite)) { | ||
| bucket.mre.Wait (5000); |
There was a problem hiding this comment.
Should do Assert.True (...)
marek-safar
approved these changes
Feb 15, 2017
marek-safar
pushed a commit
that referenced
this pull request
Feb 16, 2017
Disable some flaky tests and harden another one.
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
Disable some flaky tests and harden another one. Commit migrated from mono/mono@fd6829c
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The timer tests are disabled until they are rewritten to reflect real world behavior. Multiple reports including #52473.
ReRegisterForFinalizeTest was rewritten to use an auxilary thread to work around false pinning. Should fix #52406.