Fix bug 57918 #5545
Merged
Fix bug 57918 #5545
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Async Socket reads that need to perform multiple underlying read operations fail to return a correct total # of bytes read
|
@kg, |
marek-safar
approved these changes
Sep 12, 2017
|
should we backport this to 2017-08 ? |
|
Yes, makes a sense. @kg could you do that? |
|
@marek-safar sure. Rebase onto the 2017-08 branch and create a PR? Or something else? |
|
Yes, create a PR targeting 2017-08 branch |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for issue where async Socket reads that need to perform multiple underlying read operations fail to return a correct total # of bytes read.
https://bugzilla.xamarin.com/show_bug.cgi?id=57918
I'm not sure there's a straightforward way to write a test for this, because loopback sockets don't behave the same way. The repro steps from the bug work consistently for me (on Windows you need to use the netcat implementation from nmap).