Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[corlib/I18N] Various EncoderFallback fixes #5792

Merged
merged 6 commits into from
Oct 17, 2017

Conversation

akoeplinger
Copy link
Member

[I18N] Fix wrong charIndex in encoder fallback
We need to modify charIndex/charCount _after_ we called
the fallback encoder otherwise it'll get the wrong index.

Fixes https://bugzilla.xamarin.com/show_bug.cgi?id=45893

[corlib] Use Latin1Encoding from referencesource
Fixes https://bugzilla.xamarin.com/show_bug.cgi?id=53296

[corlib] Add tests for EncoderFallback
Also remove some debug spew.

[corlib] Add corefx System.Text.Encoding tests
This adds about 9800 Encoding related tests from corefx, all passing after the latest fixes.

[I18N] Add more encoding tests
There was very little test coverage of the I18N encodings before.

This adds a bunch of tests based on Latin1EncodingTest.cs since latin1 is quite similar to these encodings.

A few of the added tests fail in some encodings due to what looks like bugs in the implementation, disabled those temporarily, see FIXME's. (filed https://bugzilla.xamarin.com/show_bug.cgi?id=60216 for tracking)

We need to modify charIndex/charCount _after_ we called
the fallback encoder otherwise it'll get the wrong index.

Fixes https://bugzilla.xamarin.com/show_bug.cgi?id=45893
This is just confusing in the final output.
Also remove some debug spew.
This adds about 9800 Encoding related tests from corefx, all passing
after the latest fixes.
There was very little test coverage of the I18N encodings before.

This adds a bunch of tests based on Latin1EncodingTest.cs since
latin1 is quite similar to these encodings.

A few of the added tests fail in some encodings due to what looks
like bugs in the implementation, disabled those temporarily, see FIXME's.
(filed https://bugzilla.xamarin.com/show_bug.cgi?id=60216 for tracking)
@akoeplinger akoeplinger merged commit c399c78 into mono:master Oct 17, 2017
@akoeplinger akoeplinger deleted the fix-encoderfallback branch October 17, 2017 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants