[remoting] Set fRefine to false in call to Unmarshal(ObjRef) Fixes #49308 #5863
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Regression test for https://bugzilla.xamarin.com/show_bug.cgi?id=49308 We try to trick the remoting code into causing an assembly from a bad directory to be loaded too eagerly into an appdomain. If we succeed, we call a method that doesn't exist. Expected behavior is that the bad assembly is not loaded and instead we can do an Assembly.LoadFrom of a good assembly.
…9308 However if the server type has a ProxyAttribute custom attribute, set fRefine back to true. This matches logic in InternalUnmarshal in referencesource/mscorlib/system/runtime/remoting/remotingservices.cs The issue is that we may deserialize an ObjRef in some domain (domain2) when a MarshalByRef instance is passed as an argument to a method of a server object running in domain2. The observed .NET framework behavior is that this shoudl not cause domain2 to try to load the type (and consequently the assembly) of the MarshalByRef object (except in the case where it's actually a ContextBoundObject that has a ProxyAttribute). (Note however that the transparent proxy of the MarshalByRef instance in domain2 must be handled lightly - as long as its treated as an opaque reference and just loaded/stored from System.Object variables or members, the type won't be loaded). Fixes https://bugzilla.xamarin.com/show_bug.cgi?id=49308
lambdageek
requested review from
akoeplinger,
luhenry and
marek-safar
as code owners
|
This broke. |
|
This approach won't work. See Bugzilla 49308, Comment 4. Closing this PR; going to open a new PR just to push the (disabled) test case. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
However if the server type has a
ProxyAttributecustom attribute, setfRefineback to true.
This matches logic in
InternalUnmarshalinhttps://github.com/mono/mono/blob/master/mcs/class/referencesource/mscorlib/system/runtime/remoting/remotingservices.cs#L834
The issue is that we may deserialize an
ObjRefin some domain (domain2) when aMarshalByRefinstance is passed as an argument to a method of a server objectrunning in domain2. The observed .NET framework behavior is that this should
not cause domain2 to try to load the type (and consequently the assembly) of
the
MarshalByRefobject (except in the case where it's actually aContextBoundObjectthat has aProxyAttribute). (Note however that thetransparent proxy of the
MarshalByRefinstance in domain2 must be handledlightly - as long as its treated as an opaque reference and just loaded/stored
from
System.Objectvariables or members, the type won't be loaded).Fixes https://bugzilla.xamarin.com/show_bug.cgi?id=49308