[System] Improve ApplicationSettingsBase behavior #6272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ermshiperete
requested review from
akoeplinger and
marek-safar
as code owners
|
build |
This change modifies the ApplicationSettingsBaseTests so that they store the settings files in a temporary directory. This reduces the risk of failed tests because of stale files from previous test run, or from a build that runs in parallel.
When calling ApplicationSettingsBase.Save() the SettingsSaving event has to be fired.
Improve behavior of ApplicationSettingsBase class to match Windows .NET more closely. * Implement Upgrade to allow Upgrading of settings * Make SettingsPropertyValue serialization work for complex objects * Make Save and Update throw in unimplemented configurations * Changed Reload to clear PropertyValues so they are reloaded and fire PropertyChanged event for all Properties * Modified Reset to do what Reload used to do. * Added a backup Type loading for custom SettingsProviders * don't call SettingsSaving on Reset()
ermshiperete
force-pushed
the
bug-ApplicationSettingsBase-Xamarin-15818
branch
from
95b9510
to
abf0d7e
Compare
marek-safar
approved these changes
Jan 5, 2018
akoeplinger
added a commit
to akoeplinger/mono
that referenced
this pull request
Jan 5, 2018
…gsBase tests They were set in mono#6272 but since env vars are process wide we'd end up with non-existing paths once the tests are done. It is safer to unset the variables after the test.
akoeplinger
added a commit
that referenced
this pull request
Jan 6, 2018
Otherwise we'd get a "directory not empty" exception in the TestFixtureTearDown (which for some reason isn't shown in the log?). This was added in #6272
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Various changes and fixes to ApplicationsSettingsBase class to improve the behaviour, in particular it implements the
Upgrademethod, saves serialized objects, and fires theSettingsSavingevent.This fixes Xamarin bugs #15818 and #2315.
This PR supersedes #964.