Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove extra reference count on images loaded via byte array. #6656

Merged

Conversation

joncham
Copy link
Contributor

@joncham joncham commented Jan 24, 2018

Currently this extra reference count prevents dynamically loaded assemblies from being unloaded during appdomain unload.

@luhenry luhenry self-assigned this Jan 24, 2018
@luhenry
Copy link
Contributor

luhenry commented Jan 24, 2018

@monojenkins build Linux x64

@luhenry
Copy link
Contributor

luhenry commented Jan 24, 2018

@monojenkins build Linux AArch64

@luhenry
Copy link
Contributor

luhenry commented Jan 24, 2018

@monojenkins build Linux ARMv5

@joncham
Copy link
Contributor Author

joncham commented Jan 25, 2018

@monojenkins build Linux AArch64

@joncham
Copy link
Contributor Author

joncham commented Jan 25, 2018

AArch64 still failing, but not sure it's this PR
14:06:22 make[2]: *** [iface3.exe] Aborted (core dumped)

@lewurm
Copy link
Contributor

lewurm commented Jan 25, 2018

@joncham it's a roslyn crash, you can ignore it

@joncham
Copy link
Contributor Author

joncham commented Jan 27, 2018

Bump

@luhenry luhenry merged commit 65389bd into mono:master Jan 28, 2018
picenka21 pushed a commit to picenka21/runtime that referenced this pull request Feb 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants