[jit] Disable partial sharing during JITting, its only been tested in full aot mode, and doesn't seem to work with JITted methods. #7161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… full aot mode, and doesn't seem to work with JITted methods. Fixes mono#7085.
|
we should add a CI lane for hybrid AOT |
lewurm
approved these changes
Feb 21, 2018
|
It would be enough to just run this make target on normal CI. |
|
build |
|
How will this impact the hybridAOT case where the IL code has been stripped and only wrappers+trampolines are JITted? |
|
It won't, this only affects JITting. |
|
Ok, I am asking because when passing |
|
Yes, that was the problem, it also enabled it for the JIT where it was not tested, and doesn't seem to be working. |
luhenry
approved these changes
Feb 21, 2018
|
@monojenkins backport 2018-02 |
|
@monojenkins backport 2017-12 |
This was referenced Feb 21, 2018
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
… full aot mode, and doesn't seem to work with JITted methods. (mono/mono#7161) * [aot] Add hybrid aot tests. * [jit] Disable partial sharing during JITting, its only been tested in full aot mode, and doesn't seem to work with JITted methods. Fixes mono/mono#7085. Commit migrated from mono/mono@8ce0775
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7085.