Improve UWP support. #8963
Merged
Improve UWP support. #8963
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ile GetDriveType GetComputerNameW Some of these were already supported and identical code copied.
…leSize. UWP does not support GetFileSize.
jaykrell
requested review from
kumpera,
lateralusX,
luhenry and
vargaz
as code owners
jaykrell
commented
May 31, 2018
mono/metadata/icall-windows.c
Outdated
| @@ -45,25 +45,26 @@ mono_icall_module_get_hinstance (MonoReflectionModuleHandle module) | |||
| return (gpointer) (-1); | |||
| } | |||
|
|
|||
| #if G_HAVE_API_SUPPORT(HAVE_CLASSIC_WINAPI_SUPPORT) | |||
| #if G_HAVE_API_SUPPORT(HAVE_CLASSIC_WINAPI_SUPPORT) || G_HAVE_API_SUPPORT(HAVE_UWP_WINAPI_SUPPORT) | |||
There was a problem hiding this comment.
I think, you would prefer, this identical content be in icall-windows-uwp.c, instead of icall-windows.c? Identical content and identical if, still used by both classic and uwp?
jaykrell
commented
May 31, 2018
mono/metadata/w32file-win32.c
Outdated
| @@ -393,14 +393,18 @@ mono_w32file_move (const gunichar2 *path, const gunichar2 *dest, gint32 *error) | |||
| return result; | |||
| } | |||
|
|
|||
| #endif | |||
|
|
|||
| #if G_HAVE_API_SUPPORT(HAVE_CLASSIC_WINAPI_SUPPORT) || G_HAVE_API_SUPPORT(HAVE_UWP_WINAPI_SUPPORT) | |||
There was a problem hiding this comment.
I think, you would prefer, this identical content be in w32file-win32-uwp.c, instead of w32file-win32.c? Identical content and identical if, still used by both classic and uwp?
There was a problem hiding this comment.
And a few others ditto.
jaykrell
force-pushed
the
uwp
branch
20 times, most recently
from
1ecf0ac
to
c176679
Compare
Introduce fine-grained ifdefs. This should make maintenace of other subsets easier.
|
@monojenkins build failed |
|
@monojenkins build Linux AArch64 |
|
@monojenkins build failed |
lateralusX
approved these changes
Jun 11, 2018
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
* [uwp] UWP supports: ReplaceFile CopyFile LockFile UnlockFile GetDriveType GetComputerNameW Some of these were already supported and identical code copied. * Remove pre-Windows 2000 support -- use GetFileSizeEx instead of GetFileSize. UWP does not support GetFileSize. * Introduce fine-grained ifdefs. This should make maintenance of Win32 subsets easier (see w32subset.h). * Generally the code should be/stay in "classic.c" and the "uwp.c" files can/should go away. The uwp.c files were a medium-sized granularlity of reuse/replace, but the fine-grained ifdefs are better/smaller -- more code reuse. Commit migrated from mono/mono@a48ba55
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.