Add support for an output path in mono-api-diff #9556
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marek-safar
requested changes
Jul 14, 2018
|
This makes it a bit harder as we will have to move the files around and add a reference to mono.options… Right now this folder is all set up to build mono-api-info.exe. This appears to be just a single file. Is that an option? |
|
I'd love for the mono-api-info.exe to follow the standard mcs/tools setup we have everywhere else |
|
let me get on it then :) |
|
@marek-safar I moved the mono-api-diff tool into its own folder: #9563 |
Rather than always writing to the std out, provide an option to write to a file. This makes things easier for tooling but not requiring RedirectStandardOutput = true
Rather than always writing to the std out, provide an ability to write to a file using the `-o=<file>` or `--output=<file>` option. This makes things easier for tooling by not requiring RedirectStandardOutput = true
…r `--output` for consistency with existing tools
marek-safar
approved these changes
Jul 16, 2018
|
I think this is ready to be merged from my side. I tested the app with my projects, and it works as expected. |
|
@monojenkins build failed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than always writing to the std out, provide an option to write to a file. This makes things easier for tooling by not requiring
RedirectStandardOutput = true