Skip to content
This repository has been archived by the owner on Oct 4, 2021. It is now read-only.

IDE focus-in/out does a lot of IO #4383

Closed
Therzok opened this issue Mar 29, 2018 · 3 comments
Closed

IDE focus-in/out does a lot of IO #4383

Therzok opened this issue Mar 29, 2018 · 3 comments
Assignees
@mrward
Labels
Area: Shell feature-request Performance vs-sync
Milestone
7.6

Comments

@Therzok
Copy link
Contributor

Therzok commented Mar 29, 2018 •
edited by xamarin-release-manager

We should leverage the fact that we have a FileSystemWatcher to replace Workbench.SaveFileStatus/CheckFileStatus.

0.05%   <SaveFileStatus>b__0  •  5,838 ms  •  22 calls  •  MonoDevelop.Ide.Gui.Workbench+<>c__DisplayClass125_0.<SaveFileStatus>b__0
  0.05%   Start  •  5,838 ms  •  22 calls  •  System.Runtime.CompilerServices.AsyncTaskMethodBuilder.Start(TStateMachine&)
    0.05%   MoveNext  •  5,838 ms  •  22 calls  •  MonoDevelop.Ide.Gui.Workbench+<>c__DisplayClass125_0+<<SaveFileStatus>b__0>d.MoveNext
       0.04%   GetLastWriteTimeUtc  •  5,557 ms  •  288,838 calls  •  System.IO.File.GetLastWriteTimeUtc(String)
       0.00%   15 functions hidden  •  129 ms total  •  1733248 calls total
     0.00%   2 functions hidden  •  0 ms total  •  44 calls total
   0.00%   3 functions hidden  •  0 ms total  •  66 calls total

0.04%   <CheckFileStatus>b__126_0  •  5,134 ms  •  23 calls  •  MonoDevelop.Ide.Gui.Workbench.<CheckFileStatus>b__126_0
  0.04%   Start  •  5,134 ms  •  23 calls  •  System.Runtime.CompilerServices.AsyncTaskMethodBuilder.Start(TStateMachine&)
    0.04%   MoveNext  •  5,134 ms  •  23 calls  •  MonoDevelop.Ide.Gui.Workbench+<<CheckFileStatus>b__126_0>d.MoveNext
       0.04%   GetLastWriteTimeUtc  •  4,933 ms  •  288,838 calls  •  System.IO.File.GetLastWriteTimeUtc(String)
       0.00%   15 functions hidden  •  92 ms total  •  1444476 calls total
     0.00%   2 functions hidden  •  0 ms total  •  44 calls total
   0.00%   3 functions hidden  •  0 ms total  •  66 calls total

VS bug #593841
@iainx iainx self-assigned this Mar 29, 2018
iainx pushed a commit that referenced this issue Mar 30, 2018
[IDE] Use a FileSystemWatcher to take changes made while unfocused
714825e 
Track file changes made while unfocused using a FileSystemWatcher instead of
stating every file for the modification time when the application loses focus
and then again when it regains focus

Fixes GH #4383
@iainx iainx mentioned this issue Mar 30, 2018
Closed
@xamarin-release-manager xamarin-release-manager added this to the 15.8 milestone Apr 13, 2018
@mhutch mhutch reopened this Jun 16, 2018
@Therzok
Copy link
Contributor Author

Therzok commented Jun 16, 2018

This got fixed via @mrward 's file watcher integration branch.

@Therzok Therzok closed this as completed Jun 16, 2018
@mhutch
Copy link
Member

mhutch commented Jun 16, 2018

Ah. It was closed without any justification.

@xamarin-release-manager
Copy link
Contributor

[sync] [VS-45] Comment by xamarinc

Fixed in version 8.6.0.802 (master)

Pull Request #5040 merged by: Lluis Sanchez
Author: mono
Commit: e88b727 (xamarin/monodevelop)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mrward mrward

Labels
Area: Shell feature-request Performance vs-sync
Projects
None yet
Milestone
7.6
Development

No branches or pull requests
7 participants
@Therzok @mhutch @slluis @mrward @KirillOsenkov @xamarin-release-manager @iainx