[IDE] Use a FileSystemWatcher to take changes made while unfocused #4400
Conversation
Track file changes made while unfocused using a FileSystemWatcher instead of stating every file for the modification time when the application loses focus and then again when it regains focus Fixes GH #4383
|
Is the mono FSW using the corefx version right now? We need to rely on a FSW which uses the corefx version. Which means:
|
| watchers = new List<FileSystemWatcher> (); | ||
|
|
||
| // Take each workspace item and watch its base directory for any file changes | ||
| foreach (WorkspaceItem item in IdeApp.Workspace.Items) { |
There was a problem hiding this comment.
We shouldn't create and get rid of a file watcher every time we focus in/out.
We should probably iterate the solution and solution items and find the base common dir. If all paths are children of the common dir, just monitor the common dir.
Otherwise make multiple file watchers for all the paths: i.e. solution A has a project in $(slndir)/../project, we monitor $slndir and $(slndir)/../project.
In focus in/out should just toggle enable raising events.
There was a problem hiding this comment.
Ohh, that's for every solution. Okay, that's cool, but we should just keep the FSWs alive and toggle enableraisingevents.
We can use WorkspaceitemOpened to switch the paths we monitor.
There was a problem hiding this comment.
From slack:
iain holmes [7:24 PM]
I can move the watcher to the WorkspaceItem
Which is an even better idea!
There was a problem hiding this comment.
In fact, if we rewrite WorkspaceItem.FileStatusTracker to use FileSystemWatcher like it sort of was planned (all the necessary code is commented out) then we could do away with the FocusIn/FocusOut tracking altogether, no?
|
So, it seems like the mono corefx FSW is only available in master atm. I think the simplest solution we have for now is to split MonoDevelop.FSW into a different assembly and give IVT to Core and IDE so we don't expose this as API. (cc @mrward ) |
|
This is not the right approach. We need to use MonoDevelop.FSW inside the project model or FileSystemService. The check for changes on focus-in/out was a workaround for the lack of efficient FSW, but it is not the right solution now that we have good FSW. |
|
@slluis yes, that's what I was thinking. If I was to rewrite WorkspaceItem.FileStatusTracker to use the good FSW, that would remove the need for the focus-in/out workaround. Would that work instead of putting it into the project model? |
|
The focus in/focus out approach was for a non working FSW - when using for example VIM the FSW didn't throw a file change notification - was very strange. Some editors/file changes did some did not. VS.NET does the file update in their project system AFAIK. |
|
|
||
| // Take each workspace item and watch its base directory for any file changes | ||
| foreach (WorkspaceItem item in IdeApp.Workspace.Items) { | ||
| var watcher = new FileSystemWatcher (item.BaseDirectory); |
There was a problem hiding this comment.
Projects can contain files that are outside of the base directory of the project.
|
That patch doesn't work for files that are not in a project. The old approach was just a work around but was correct in that use case. |
|
This will need to be rebased so it works with new CI lanes. |
|
@mrward is this fixed in file-watcher-integration PR? |
|
@Therzok - Yes this is fixed on the file-watcher-integration branch. I guess we can close this. |
Track file changes made while unfocused using a FileSystemWatcher instead of
stating every file for the modification time when the application loses focus
and then again when it regains focus
Fixes GH #4383