Skip to content
This repository has been archived by the owner on Oct 4, 2021. It is now read-only.

MonoDevelop overwrites project GUID to be lowercase instead of uppercase #5976

Closed
NatElkins opened this issue Sep 15, 2018 · 5 comments
Closed

Comments

@NatElkins
Copy link

NatElkins commented Sep 15, 2018

Steps to repro:

  1. Check out https://github.com/microsoft/visualfsharp
  2. Open FSharp.sln using MonoDevelop.
  3. Rename any project.
  4. In repo, do git status
  5. Observe that there are a bunch of updates similar to the following:
-Project("{F2A71F9B-5D33-465A-A702-920D77279786}") = "FSharp.Tests.FSharpSuite", "tests\fsharp\FSharp.Tests.FSharpSuite.fsproj", "{C163E892-5BF7-4B59-AA99-B0E8079C67C4}"
+Project("{f2a71f9b-5d33-465a-a702-920d77279786}") = "FSharp.Tests.FSharpSuite", "tests\fsharp\FSharp.Tests.FSharpSuite.fsproj", "{C163E892-5BF7-4B59-AA99-B0E8079C67C4}"

Note that F2A71F9B-5D33-465A-A702-920D77279786 gets changed to f2a71f9b-5d33-465a-a702-920d77279786.

I believe that MonoDevelop should not change the casing of these GUIDs.

VS bug #686313

@knocte
Copy link
Contributor

knocte commented Sep 16, 2018

what version of MonoDevelop are you using?

@NatElkins
Copy link
Author

7.5 (build 1255)

I see it replaces other project GUIDs as well, for example:

-Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "ProjectSystem.Base", "vsintegration\src\FSharp.ProjectSystem.Base\Project\ProjectSystem.Base.csproj", "{B700E38B-F8C0-4E49-B5EC-DB7B7AC0C4E7}"
+Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "ProjectSystem.Base", "vsintegration\src\FSharp.ProjectSystem.Base\Project\ProjectSystem.Base.csproj", "{B700E38B-F8C0-4E49-B5EC-DB7B7AC0C4E7}"

@mrward
Copy link
Member

mrward commented Sep 18, 2018

The problem with the .NET Core project type guid 9A19103F-16F7-4668-BE54-9A1E7A4F7556 being changed back to the C# project type guid has been fixed in master and 7.7 - #5864

I think the problem with the F# project type guid is that it is defined in lowercase in the F# addin -

<DotNetProjectType language="F#" extension="fsproj" guid="{f2a71f9b-5d33-465a-a702-920d77279786}" type="MonoDevelop.FSharp.FSharpProject"/>
- it should be using uppercase to be consistent with Visual Studio on Windows.

@xamarin-release-manager
Copy link
Contributor

Fixed in version 7.8.0.626 (master)

Pull Request #6109 merged by: Jason Imison
Author: knocte
Commit: e50935b (mono/monodevelop)

@xamarin-release-manager
Copy link
Contributor

Fixed in version 8.0.0.197 (release-8.0)

Pull Request #6109 merged by: Jason Imison
Author: knocte
Commit: e50935b (mono/monodevelop)

knocte added a commit to nblockchain/geewallet that referenced this issue Oct 10, 2018
Due to this VS4Mac/MonoDevelop bug[1], GUIDs were incorrectly
lowercase here. Let's make them uppercase so that VS4Win doesn't
change again (and VS4Mac won't soon either, in v7.7).

[1] mono/monodevelop#5976
knocte added a commit to nblockchain/geewallet that referenced this issue Oct 10, 2018
Due to this VS4Mac/MonoDevelop bug[1], GUIDs were incorrectly
lowercase here. Let's make them uppercase so that VS4Win doesn't
change again (and VS4Mac won't soon either, in v7.8).

[1] mono/monodevelop#5976
@xamarin-release-manager xamarin-release-manager added this to the 7.8 milestone Dec 1, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants