Skip to content
This repository has been archived by the owner on Oct 4, 2021. It is now read-only.

FsharpBinding: uppercase F# project GUID to be consistent with VS4win #6109

Merged
merged 1 commit into from
Sep 27, 2018
Merged

FsharpBinding: uppercase F# project GUID to be consistent with VS4win #6109

merged 1 commit into from
Sep 27, 2018

Conversation

knocte
Copy link
Contributor

@knocte knocte commented Sep 27, 2018

Fixes #5976

@mrward mrward requested a review from nosami September 27, 2018 10:25
@nosami
Copy link
Member

nosami commented Sep 27, 2018

Looks like this needs changing too -

monodevelop/main/src/addins/MonoDevelop.DotNetCore/MonoDevelop.DotNetCore.Tests/MonoDevelop.DotNetCore.Tests/DotNetCoreProjectTemplateTests.cs

Line 359 in f8fcfdc

return "{f2a71f9b-5d33-465a-a702-920d77279786}";

@msftclas
Copy link

msftclas commented Sep 27, 2018 •
edited
Loading

CLA assistant check
All CLA requirements met.

@knocte
Copy link
Contributor Author

knocte commented Sep 27, 2018

Thanks, done.

@nosami nosami merged commit e50935b into mono:master Sep 27, 2018
@xamarin-release-manager xamarin-release-manager mentioned this pull request Sep 27, 2018
Closed
@nosami
Copy link
Member

nosami commented Sep 27, 2018

Thanks @knocte !

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Therzok Therzok Therzok approved these changes

@nosami nosami nosami approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@knocte @nosami @msftclas @Therzok