[Ide] Improve DnD handling #4777
Conversation
* Open multiple solutions in one workspace * Support dropping of solution folders
| try { | ||
| if (Services.ProjectService.IsWorkspaceItemFile (filePath)) |
There was a problem hiding this comment.
I'd like to keep the old behavior here. If a user drops a solution file to the IDE, it is very likely the intention to open the solution, not edit the solution file. On the other hand, if the project file is being dropped, it is very likely the intention is to edit the project file (notice that IsWorkspaceItemFile will return true for solutions, but false for projects).
There was a problem hiding this comment.
It's not IDE, it's only dropping into the document notebook tabbar, IDE (toolbar and anywhere outside of the editor, + welcome screen) will just open the solution (not in the editor). If I drop something into the tabbar, which is only this area:
I expect it to be opened in the editor.
There was a problem hiding this comment.
Actually many other areas don't treat solution files correctly at all. For example the solution pad should open a dropped solution, but it doesn't anything with it. I'll fix it...
There was a problem hiding this comment.
Yeah, got it, I missed the case when no document is open. Fixed with: 5eb56ba
* Open multiple solutions in one workspace * Support dropping of solution folders (copy behaviour from fb38d90)
This copies the welcome page behaviour when the Ctrl or Cmd (on Mac) key is pressed.
|
Approved by QA. |
This fixes several DnD handling issues:
projectssolutions dropped into the documents notebook tab-bar are (ones sln as text file for editing)