Skip to content
This repository has been archived by the owner on Oct 4, 2021. It is now read-only.

[NUnit] Fix prompt always displayed when running NUnit project. #828

Merged
merged 1 commit into from
Mar 31, 2015

Conversation

mrward
Copy link
Member

@mrward mrward commented Mar 26, 2015

Fixed bug #28083 - When running an NUnit project, Xamarin Studio
always asks "An application is already running and will have to be
stopped. Do you want to continue?"
https://bugzilla.xamarin.com/show_bug.cgi?id=28083

When an NUnit project was run, either from the main toolbar menu or
from the Run menu, with Start Debugging or Start Without Debugging,
the NUnit addin was treating the running of the tests as a separate
run operation which would cause a prompt to be displayed to the user.
Now when the NUnit project is run the ProjectOperation's
CurrentRunOperation is not checked, nor modified by, the NUnit addin
since it is part of the CurrentRunOperation and not a separate
operation.

The user will still be prompted if they are debugging another project
in the solution and then try to run the unit tests from the Unit Tests
pad.

The NUnitProjectServiceExtension now uses code that was previously
commented out to fix bug #18130. With the change made to the
NUnitService to prevent it from changing the CurrentRunOperation
the bug 18138 is still fixed.
https://bugzilla.xamarin.com/show_bug.cgi?id=18130

Fixed bug #28083 - When running an NUnit project, Xamarin Studio
always asks "An application is already running and will have to be
stopped. Do you want to continue?"
https://bugzilla.xamarin.com/show_bug.cgi?id=28083

When an NUnit project was run, either from the main toolbar menu or
from the Run menu, with Start Debugging or Start Without Debugging,
the NUnit addin was treating the running of the tests as a separate
run operation which would cause a prompt to be displayed to the user.
Now when the NUnit project is run the ProjectOperation's
CurrentRunOperation is not checked, nor modified by, the NUnit addin
since it is part of the CurrentRunOperation and not a separate
operation.

The user will still be prompted if they are debugging another project
in the solution and then try to run the unit tests from the Unit Tests
pad.

The NUnitProjectServiceExtension now uses code that was previously
commented out to fix bug #18130. With the change made to the
NUnitService to prevent it from changing the CurrentRunOperation
the bug 18138 is still fixed.
https://bugzilla.xamarin.com/show_bug.cgi?id=18130
@monojenkins
Copy link
Contributor

Hello! I'm the build bot for the Mono project. I need approval from a Mono team member to build this pull request. A team member should reply with "approve" to approve a build of this pull request, "whitelist" to whitelist this and all future pull requests from this contributor, or "build" to explicitly request a build, even if one has already been done. Contributors can ignore this message.

@mrward
Copy link
Member Author

mrward commented Mar 26, 2015

whitelist

@slluis
Copy link
Member

slluis commented Mar 31, 2015

Can you make a PR for 5.9?

slluis added a commit that referenced this pull request Mar 31, 2015
…prompts

[NUnit] Fix prompt always displayed when running NUnit project.
@slluis slluis merged commit 1a68047 into master Mar 31, 2015
@Therzok Therzok deleted the bug-28083-run-nunit-project-always-prompts branch July 13, 2015 11:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants