This repository has been archived by the owner on Oct 4, 2021. It is now read-only.
[release-8.4] Abstracts IPropertyGrid and uses in Preferences to fix a11c issues #9165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
monojenkins
force-pushed
the
backport-pr-8937-to-release-8.4
branch
from
6c86e6d
to
5054552
Compare
monojenkins
force-pushed
the
backport-pr-8937-to-release-8.4
branch
from
5054552
to
ec4e977
Compare
|
@monojenkins rebase |
1 similar comment
|
@monojenkins rebase |
monojenkins
force-pushed
the
backport-pr-8937-to-release-8.4
branch
from
ec4e977
to
33c08d8
Compare
… Formatting F# panel
… Fixes VSTS #1001627 - A11Y_Xamarin Designers_Property pane_keyboard : User is unable to open the “Edit” button by using space/enter keys Fixes VSTS #1001625 - A11Y_Xamarin Designers_Property pane_keyboard : User is unable to check/uncheck the “Automatic tree” check box by using space key
monojenkins
force-pushed
the
backport-pr-8937-to-release-8.4
branch
from
33c08d8
to
cf8910e
Compare
sevoku
approved these changes
Oct 31, 2019
This was referenced Oct 31, 2019
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTES: Proppy doesn't expose any API to allow us remove the toolbar
xamarin/Xamarin.PropertyEditing#663
Also there is an issue in numeric decimal editors in Culture separator symbol non ENGLISH based
xamarin/Xamarin.PropertyEditing#662
Fixes VSTS #1003417 - Replace current F# format preference panel to use native Proppy
Fixes VSTS #1003416 - Replace current XML format preference panel to use native Proppy
Fixes VSTS #1002622 - Add a mechanism outside proppy to hide toolbar
Fixes VSTS #637121 - Accessibility: Preferences - Code Formatting: Unable to access Layout,Refracting,Spacing categorized formattings using keyboard.
Fixes VSTS #637246 - Accessibility: Preferences - Code Formatting F#: Not able to access Attributes,Document,Elements and it’s inside elements under 'Source code -> XML document'.
Fixes VSTS #1001600 - A11Y_Xamarin Designers_Property pane_keyboard : Keyboard is getting trapped at “Automatic tree” check box
Fixes VSTS #1001627 - A11Y_Xamarin Designers_Property pane_keyboard : User is unable to open the “Edit” button by using space/enter keys### Preferences CodeFormating XML
Fixes VSTS #1001625 - A11Y_Xamarin Designers_Property pane_keyboard : User is unable to check/uncheck the “Automatic tree” check box by using space key
Preferences CodeFormating F#
Backport of #8937.
/cc @netonjm