This repository has been archived by the owner on Oct 4, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1k
Abstracts IPropertyGrid and uses in Preferences to fix a11c issues #8937
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Therzok
reviewed
Oct 16, 2019
main/src/addins/MonoDevelop.DesignerSupport/MonoDevelop.DesignerSupport/MacPropertyGrid.cs
Show resolved
Hide resolved
netonjm
force-pushed
the
proppy-native-preferences
branch
2 times, most recently
from
October 17, 2019 12:16
2e5448d
to
6c5e888
Compare
netonjm
force-pushed
the
proppy-native-preferences
branch
from
October 17, 2019 12:50
d7f30d8
to
4db687c
Compare
Branch rebased and ready to review @sevoku |
Therzok
reviewed
Oct 21, 2019
main/src/addins/MonoDevelop.DesignerSupport/MonoDevelop.DesignerSupport/MacPropertyGrid.cs
Outdated
Show resolved
Hide resolved
Therzok
reviewed
Oct 21, 2019
main/src/addins/MonoDevelop.DesignerSupport/MonoDevelop.DesignerSupport/MacPropertyGrid.cs
Outdated
Show resolved
Hide resolved
Therzok
reviewed
Oct 21, 2019
...signerSupport/MonoDevelop.DesignerSupport/NativePropertyEditor/ComponentModelObjectEditor.cs
Outdated
Show resolved
Hide resolved
netonjm
force-pushed
the
proppy-native-preferences
branch
2 times, most recently
from
October 23, 2019 01:29
11f2b52
to
78062d4
Compare
@monojenkins rebase |
monojenkins
force-pushed
the
proppy-native-preferences
branch
from
October 23, 2019 18:20
08f37e3
to
765e352
Compare
Therzok
approved these changes
Oct 24, 2019
Testing this the problems I ran into:
Once you get inside the properties control everything seems good. Tabbing around is OK. Voice over works. Only problem is the the reset button/image being read as Properties, image, mentioned above. |
Therzok
reviewed
Oct 27, 2019
main/src/core/MonoDevelop.Ide/MonoDevelop.Components.Commands/CommandManager.cs
Show resolved
Hide resolved
Latest build problems:
|
I've tried the latest build now too and see the same issues:
I think this worked before, now proppy is not part of the focus chain at all.
We should fix that, should be just a matter of setting a11y props on the table view. @netonjm can we fix these two problems ^^? The following issues are external in proppy, we should file them separately, but this shouldn't block this PR:
|
netonjm
force-pushed
the
proppy-native-preferences
branch
from
October 29, 2019 18:04
e56492b
to
7926575
Compare
Fixes VSTS #1001627 - A11Y_Xamarin Designers_Property pane_keyboard : User is unable to open the “Edit” button by using space/enter keys Fixes VSTS #1001625 - A11Y_Xamarin Designers_Property pane_keyboard : User is unable to check/uncheck the “Automatic tree” check box by using space key
monojenkins
force-pushed
the
proppy-native-preferences
branch
from
October 31, 2019 08:44
afdb5b7
to
3904854
Compare
sevoku
approved these changes
Oct 31, 2019
sevoku
added
verified
The feature or bug fix has been tested and it works
and removed
do-not-merge
labels
Oct 31, 2019
@monojenkins backport release-8.4 |
This was referenced Oct 31, 2019
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTES: Proppy doesn't expose any API to allow us remove the toolbar
xamarin/Xamarin.PropertyEditing#663
Also there is an issue in numeric decimal editors in Culture separator symbol non ENGLISH based
xamarin/Xamarin.PropertyEditing#662
Fixes VSTS #1003417 - Replace current F# format preference panel to use native Proppy
Fixes VSTS #1003416 - Replace current XML format preference panel to use native Proppy
Fixes VSTS #1002622 - Add a mechanism outside proppy to hide toolbar
Fixes VSTS #637121 - Accessibility: Preferences - Code Formatting: Unable to access Layout,Refracting,Spacing categorized formattings using keyboard.
Fixes VSTS #637246 - Accessibility: Preferences - Code Formatting F#: Not able to access Attributes,Document,Elements and it’s inside elements under 'Source code -> XML document'.
Fixes VSTS #1001600 - A11Y_Xamarin Designers_Property pane_keyboard : Keyboard is getting trapped at “Automatic tree” check box
Fixes VSTS #1001627 - A11Y_Xamarin Designers_Property pane_keyboard : User is unable to open the “Edit” button by using space/enter keys### Preferences CodeFormating XML
Fixes VSTS #1001625 - A11Y_Xamarin Designers_Property pane_keyboard : User is unable to check/uncheck the “Automatic tree” check box by using space key
Preferences CodeFormating F#