This repository has been archived by the owner on Aug 8, 2024. It is now read-only.
[unix] Fix rebuilds caused by resx containing fileref with windows path #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When running on !windows, if a resx contains a fileRef like ..
```
<data name="TextFile1" type="System.Resources.ResXFileRef, System.Windows.Forms">
<value>..\Resources\TextFile1.txt;System.String, mscorlib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089;Windows-1252</value>
</data>
```
.. with the path containing backslashes, then we end up treating the whole
thing as filename and thus subsequent checks for file changes etc fail. This
causes the resx to be processed every time `GenerateResource` task is run, which
can cause costly rebuilds.
Issue: mono/mono#7184
akoeplinger
approved these changes
Mar 16, 2018
| { | ||
| // This WriteLine is a hack. On a slow machine, the Tasks unittest fails because remoting | ||
| // times out the object used for remoting console writes. Adding a write in the middle of | ||
| // keeps remoting from timing out the object. |
|
@akoeplinger backport to 2018-02 only? |
|
@radical yeah, Marek put mono/mono#7184 into the 2018-02 milestone and since it isn't a regression probably not important enough for 2017-12 |
radical
added a commit
that referenced
this pull request
Mar 16, 2018
…th (#44) (#45) When running on !windows, if a resx contains a fileRef like .. ``` <data name="TextFile1" type="System.Resources.ResXFileRef, System.Windows.Forms"> <value>..\Resources\TextFile1.txt;System.String, mscorlib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089;Windows-1252</value> </data> ``` .. with the path containing backslashes, then we end up treating the whole thing as filename and thus subsequent checks for file changes etc fail. This causes the resx to be processed every time `GenerateResource` task is run, which can cause costly rebuilds. Issue: mono/mono#7184 (cherry picked from commit dfb274e)
radical
added a commit
that referenced
this pull request
May 5, 2018
…th (#44) (dotnet#3234) When running on !windows, if a resx contains a fileRef like .. ``` <data name="TextFile1" type="System.Resources.ResXFileRef, System.Windows.Forms"> <value>..\Resources\TextFile1.txt;System.String, mscorlib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089;Windows-1252</value> </data> ``` .. with the path containing backslashes, then we end up treating the whole thing as filename and thus subsequent checks for file changes etc fail. This causes the resx to be processed every time `GenerateResource` task is run, which can cause costly rebuilds. Issue: mono/mono#7184 (cherry picked from commit 177facd)
radical
added a commit
that referenced
this pull request
Jun 2, 2018
…th (#44) (dotnet#3234) When running on !windows, if a resx contains a fileRef like .. ``` <data name="TextFile1" type="System.Resources.ResXFileRef, System.Windows.Forms"> <value>..\Resources\TextFile1.txt;System.String, mscorlib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089;Windows-1252</value> </data> ``` .. with the path containing backslashes, then we end up treating the whole thing as filename and thus subsequent checks for file changes etc fail. This causes the resx to be processed every time `GenerateResource` task is run, which can cause costly rebuilds. Issue: mono/mono#7184
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running on !windows, if a resx contains a fileRef like ..
.. with the path containing backslashes, then we end up treating the whole
thing as filename and thus subsequent checks for file changes etc fail. This
causes the resx to be processed every time
GenerateResourcetask is run, whichcan cause costly rebuilds.
Issue: mono/mono#7184