This repository has been archived by the owner on Sep 4, 2024. It is now read-only.
Optimize Popover impl. + support Gtk based reference widgets #639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slluis
approved these changes
Feb 9, 2017
|
BTW, now that Xamarin.Mac is open source, we should remove MonoMac support. |
Fill the internal ContentView (including the popover arrow) with the background color and don't modify the child widget.
DidClose is not guaranteed to be executed before the Popover or its Delegate have been Disposed and/or GCd and may crash.
The new implementation is more complex. It relies on a back reference to the Backend and the NSPopover Delegate, hence we can't abuse the Xwt ViewController fur custom implementations.
sevoku
force-pushed
the
mac-cross-toolkit-popovers
branch
from
8377540
to
2fcaeb7
Compare
garuma
approved these changes
Feb 16, 2017
| WidgetSpacing padding = 0; | ||
| if (Backend != null) | ||
| padding = Backend.Frontend.Padding; | ||
| View.AddConstraints (new NSLayoutConstraint [] { |
There was a problem hiding this comment.
Should likely disable the NativeChild's translatesAutoresizingMaskIntoConstraints property
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes various PopoverBackend fixes:
Closedevent was missingPaddingwas missingBackgroundColorfixedThe last commit 29c2803 allows to attach a Popover to a Gtk based Widget.