Skip to content
This repository has been archived by the owner on Sep 4, 2024. It is now read-only.

Add WindowFrame.BackgroundColor property #649

Merged
merged 1 commit into from
Mar 28, 2017

Conversation

sevoku
Copy link
Member

@sevoku sevoku commented Mar 3, 2017

No description provided.

@sevoku sevoku added the feature label Mar 3, 2017
@sevoku sevoku force-pushed the add-window-background-color branch from b456812 to 94b8c40 Compare March 3, 2017 21:18
@slluis
Copy link
Member

slluis commented Mar 4, 2017

I feel this belongs to Window, not WindowFrame.

@sevoku
Copy link
Member Author

sevoku commented Mar 4, 2017

Hhm, but its the same as Opacity. And depending on the toolkit the BG color is applied on the titlebar and window border as well (Cocoa does it definitely).

@slluis
Copy link
Member

slluis commented Mar 6, 2017

I guess WindowFrame is not a good name. I added WindowFrame because I needed to represent a window which may have not been created by XWT. For example, when embedding an XWT widget inside an existing Gtk or Cocoa UI, the widget will still have a parent window, but it can't be an XWT.Window instance because that window is not under control of XWT, so it is a WindowFrame. So WindowFrame is intended to be a very simple representation of a Window, with little functionality. I guess in some cases it is not 100% clear whether a functionality belongs to WindowFrame or Window. For layouting properties such as Padding it is obvious it belongs to Window, since it requires the cooperation of XWT content widgets.

If GTK, Cocoa and WPF support BackgroundColor directly, I guess it could go into WindowFrame too, but I have the feeling that having it in Window makes more sense. It doesn't seem correct to allow modifying the content of a Window which you don't control. Opacity is kind of an edge case, since it is usually implemented by the window manager, and it has effect on the windows as a whole. It does change the window content, it just changes the way it is presented to the user (like changing visibility).

@sevoku
Copy link
Member Author

sevoku commented Mar 6, 2017

Ok, that makes sense. Lets move it to Window then.

@sevoku sevoku force-pushed the add-window-background-color branch from 94b8c40 to 2e73258 Compare March 6, 2017 16:38
@sevoku
Copy link
Member Author

sevoku commented Mar 6, 2017

@slluis done

@sevoku sevoku merged commit 8a58fff into mono:master Mar 28, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants